GithubHelp home page GithubHelp logo

Comments (3)

JoshuaKGoldberg avatar JoshuaKGoldberg commented on June 1, 2024

Err, remove or fix? My preference would be to use it to enforce formatting on Git commit, and remove any linting.

from mocha.

JoshuaKGoldberg avatar JoshuaKGoldberg commented on June 1, 2024

Explaining why I'm not in favor of this: Husky makes it a lot harder (admittedly, not impossible) to make commits locally that aren't well-formatted.

Not every contributor uses a nicely set up editor like VS Code with format-on-save. They might be new to development, and/or using something like Nodepad++, and/or just running with odd settings. For those edge cases, it's inconvenient to have to be told by CI that your change has formatting issues.

So from my perspective, there's very little downside to setting up formatting as a Git commit hook locally (node_modules/ is already going to be large; Knip recognizes properly set up Husky situations). And the upside is we have a bit more consistent, reliable of a dev experience - especially for new folks.

Which brings up a question: why do you two want to remove it? Assuming we're sticking to formatting on commit hooks and not linting or other more intrusive and/or time-intensive tasks... why not?

from mocha.

voxpelli avatar voxpelli commented on June 1, 2024

I use husky on all of my own projects so I’m totally up for keeping it. I can’t remember exact reason why we discussed dropping it

from mocha.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.