Comments (3)
Err, remove or fix? My preference would be to use it to enforce formatting on Git commit, and remove any linting.
from mocha.
Explaining why I'm not in favor of this: Husky makes it a lot harder (admittedly, not impossible) to make commits locally that aren't well-formatted.
Not every contributor uses a nicely set up editor like VS Code with format-on-save. They might be new to development, and/or using something like Nodepad++, and/or just running with odd settings. For those edge cases, it's inconvenient to have to be told by CI that your change has formatting issues.
So from my perspective, there's very little downside to setting up formatting as a Git commit hook locally (node_modules/
is already going to be large; Knip recognizes properly set up Husky situations). And the upside is we have a bit more consistent, reliable of a dev experience - especially for new folks.
Which brings up a question: why do you two want to remove it? Assuming we're sticking to formatting on commit hooks and not linting or other more intrusive and/or time-intensive tasks... why not?
from mocha.
I use husky on all of my own projects so Iβm totally up for keeping it. I canβt remember exact reason why we discussed dropping it
from mocha.
Related Issues (20)
- π Bug: Eleventy template builds crash with 'unexpected token at ": string, msg..."' HOT 1
- π Bug: mocha does not compatible with node.js test runner HOT 1
- π Docs: Remove Matomo from the website HOT 1
- π Bug: Failed to run tests with a large tests count HOT 1
- π Repo: Tests broken on main for xunit after conflicting merge
- π Repo: Replace `nps` with ordinary npm scripts
- π Bug: Audit and fix accessibility for browser reporter
- π Feature: Unify `--ignore` and `--watch-ignore` and make the patterns recursive
- π Bug: Unit test cases taking too much time to execute HOT 1
- π Bug: <short description of the bug>
- `skip` shows "pending" instead of "skipped"
- π Bug: Test titles not shown for ES dynamic imports
- π Bug: mocha fails silently on invalid `package.json` section
- Bump chokidar HOT 3
- π Bug: [email protected] has a performance bug HOT 1
- π Bug: Error Importing TypeScript Class: Only .js Extension Supported, Not .ts HOT 1
- π Bug: when using exports interface for tests, there's no file on suites objects HOT 2
- π Feature: Update glob from 8.1.0 which is no longer supported HOT 1
- π Bug: Watch + mochaHooks inconsistent state on re-runs
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mocha.