Map mappings are incorrect about mcpbot-issues

[bspkrs]

Is your name really Starbuck?

On Aug 17, 2015, at 3:28 PM, Starbuck Johnson [email protected] wrote:

Version 1.8

For func_82567_a the parameter p_82567_8_ is not z it should be rotation. Similarly for the same method parameter p_82567_6_ is actually worldZ not y, finally for parameters the parameter p_82567_4_ should be mapped to worldX as x doesn't show the fact that it's not a map canvas x coordinate, it's a world relative coordinate. The method itself should be called updateMapDecorations not updatePlayersVisibleOnMap.

The field field_76203_h should be called mapDecorations as that's what it actually stores, not specifically players or entities. The name is misleading and confuses the fact that non-entity entries are accepted and perfectly safe.

—
Reply to this email directly or view it on GitHub.

[Lunaphied]

Yes it is.

[bspkrs]

The params are now fixed. I will add the field/method name refactorings to the list for 1.8.8.