Comments (5)
There's a new check for invalid termination condition input, and the two failing tests look to be hitting that. It looks like they don't specify a time scale for the termination condition:
Lines 413 to 422 in 2e9cd9c
A correct example:
MDF/examples/PsyNeuLink/SimpleFN.json
Lines 15 to 27 in 2e9cd9c
In prior graph-scheduler versions, that condition would have been silently ignored.
This line looks like the culprit:
from mdf.
I'm not sure the exact intent of the model, but my guess would be that
termination={"environment_state_update": cond_term},
would be the replacement to make.
Maybe @davidt0x has input
from mdf.
@davidt0x Did you suggest in our last call that your latest PR solved this issue?
from mdf.
I did suggest that but I forgot to include the fix, will generate another PR, sorry for the confusion.
from mdf.
This issue is fixed with PR #524
from mdf.
Related Issues (20)
- Remove sphinx pin to 3.x? HOT 1
- torch.fx to MDF
- Support for populations/templates HOT 1
- Support for cyclical graphs HOT 3
- onnx 1.14 incompatibility HOT 2
- Py3.10 builds failing due to fastkde HOT 1
- simple_pytorch_to_mdf.py breaking in pytorch 2.0 HOT 2
- Example for testing with Keras->MDF conversion: 3D convolutional neural network HOT 1
- Refactor PyTorch_MDF examples to ease benchmarking HOT 2
- Keras to MDF HOT 1
- Support PyTorch v2.2.0
- ACTR importer condition typo? HOT 1
- Tasks/ Milestones HOT 1
- Missing Link to Functions List in Parameter Section in Documentation HOT 4
- Incorrect GitHub Edit Links in 'modeci_mdf' API Reference Section
- Failure of tests on macos-latest on graphviz setup step
- Allow parameters in Graph to be accessible from any node?
- pypi refusing to make new release as modeci requires verified email HOT 2
- Create a Streamlit based app to run a generic MDF model HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mdf.