GithubHelp home page GithubHelp logo

Support latest graph_scheduler about mdf HOT 5 CLOSED

pgleeson avatar pgleeson commented on July 23, 2024
Support latest graph_scheduler

from mdf.

Comments (5)

kmantel avatar kmantel commented on July 23, 2024

There's a new check for invalid termination condition input, and the two failing tests look to be hitting that. It looks like they don't specify a time scale for the termination condition:

"termination": {
"check_term_true": {
"type": "JustRan",
"kwargs": {
"dependencies": [
"check_termination"
]
}
}
}

A correct example:

"termination": {
"environment_sequence": {
"type": "Never",
"args": {}
},
"environment_state_update": {
"type": "AllHaveRun",
"args": {
"dependencies": []
}
}
}
},

In prior graph-scheduler versions, that condition would have been silently ignored.

This line looks like the culprit:

termination={"check_term_true": cond_term},

from mdf.

kmantel avatar kmantel commented on July 23, 2024

I'm not sure the exact intent of the model, but my guess would be that

 termination={"environment_state_update": cond_term}, 

would be the replacement to make.

Maybe @davidt0x has input

from mdf.

pgleeson avatar pgleeson commented on July 23, 2024

@davidt0x Did you suggest in our last call that your latest PR solved this issue?

from mdf.

davidt0x avatar davidt0x commented on July 23, 2024

I did suggest that but I forgot to include the fix, will generate another PR, sorry for the confusion.

from mdf.

davidt0x avatar davidt0x commented on July 23, 2024

This issue is fixed with PR #524

from mdf.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.