Comments (6)
Problem might be, that the Option tolerance is preset using a string:
[Option('t', "tolerance", DefaultValue = "0.002", Required = false, HelpText = "Set the width of the tube at discontinuity in x-direction [Default is 0.002].")]
public string Tolerance { get; set; }
Removing the default value should fix the issue.
from csv-compare.
Unfortunately that solution is still locale dependent, which in our case causes problems since we use CSV Compare from within our software, i.e. the calls are done from scripts.
IMHO it's bad design to have a program command line dependent on the users locale settings.
This might be a separate issue though.
from csv-compare.
Can you tell me which locale fails and which settings? The code already implemented in csv compare for parsing the value for the tolerance handles "0.002", "0,002" and "2e-3" and should not depent on locale settings; I'm going to check this. The program should of course not be locale dependent; the problem here (I think) was the hard coded string for the default value. Without this hard coded value, the program should correctly parse the tolerance in any of the 3 formattings.
from csv-compare.
Ok that is good to hear, then we are on the same page. However the current behaviour that we see with Christian Andersson's (from MA ticket linked above) build of r8061 is strange, it really looks like if it is locale dependent.
The computers that I have problems with have Windows 7 with Swedish number/date formatting, i.e. if you go Control Panel -> Region and Language -> Additional settings... There the decimal symbol is a comma (,). If we try to run CSV Compare without -t set we get an error. Presumably since the default value is 0.002 and given the language settings that is not a valid number. if -t is specified to i.e. 0,001 then the error goes away and the tolerance seems to be correct.
Also, it works as exepcted if I change the decimal symbol in the language settings to a dot.
So sorry to say it but it really seems as if computer locale affects the program.
from csv-compare.
I found the issue. It was a bug in the code. I used the commandline option directly and not the parsed object. The default value can stay as it is. I debugged it using swedish locale settings on my computer.
from csv-compare.
Nice :)
Thank you for the help.
from csv-compare.
Related Issues (20)
- Change version system in linux make file
- Few error points causes strange error bar HOT 4
- Use one time vector for results in html reports HOT 2
- Incorrect handling of trajectory endpoints HOT 3
- Locale-dependent error value in compare_failed.log
- Index out of bound exception HOT 1
- Missing variables are not always skipped HOT 7
- Absolute vs Relative URLs HOT 5
- Result compare error
- Set tolerance of tube in y-axis HOT 1
- Report directory with trailing backslash (Win)
- Improve error message if first column header is not vanilla time
- Detailed documentation HOT 8
- File remains in temporary folder after run HOT 2
- csvFileCompare fails since 2.0.1 HOT 10
- Compare.exe does not accept relative .csv files from current working directory HOT 1
- NaN and Infinity support HOT 3
- The --tolerance option doesn't work as expected (or: documentation needs to be improved) HOT 12
- Junit support HOT 2
- Error while building using Visual Studio
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from csv-compare.