Comments (3)
Yep, that all makes sense. You can't use the same memory pool to share instances that are created using multiple different prefabs. One issue I see with your solution is that using code could pass different prefabs. Which might not be an issue if you're injecting it AsTransient
but worth pointing out. Another solution would be to use a dictionary like this:
public class BulletFactory
{
readonly Dictionary<GameObject, IMemoryPool<Bullet>> _pools =
new Dictionary<GameObject, IMemoryPool<Bullet>>();
readonly DiContainer _container;
readonly MemoryPoolSettings _settings;
public BulletFactory(DiContainer container, MemoryPoolSettings settings)
{
_container = container;
_settings = settings;
}
public void Despawn(GameObject prefab, Bullet bullet)
{
_pools[prefab].Despawn(bullet);
}
public Bullet Spawn(GameObject prefab)
{
IMemoryPool<Bullet> pool;
if (!_pools.TryGetValue(prefab, out pool))
{
pool = _container.Instantiate<MonoMemoryPool<Bullet>>(
new object[] { _settings, new FuncFactory<Bullet>(() => _container.InstantiatePrefabForComponent<Bullet>(prefab))});
_pools.Add(prefab, pool);
}
return pool.Spawn();
}
}
public class FuncFactory<T> : IFactory<T>
{
readonly Func<T> _factoryMethod;
public FuncFactory(Func<T> factoryMethod)
{
_factoryMethod = factoryMethod;
}
public T Create()
{
return _factoryMethod();
}
}
from zenject.
Spent some time to solve this problem.
Right now in Extenject each of MonoMemoryPool<TParam1..TParam5,TContract>
(one till five parameters) classes is using MemoryPoolBase<TContract>
with only one parameter, which holds IFactory<TContract>
(no parameters in Create method). So there is no way to pass additional parameters to the factrory. This might be a good place for further improvements.
However, I came to the conclusion that the idea of using MonoMemoryPool
with Prefab[Resource]Factory
is broken by design. If you pass different prefabs to the MonoMemoryPool.Spawn
, the pool will contain different prefabs after MonoMemoryPool.Despawn
. This can lead to the undefined behaviour when someone will reuse them.
But if someone really need to pass parameters from memory pool to underlaying factory you can use something like that.
from zenject.
@svermeulen Hi , Can you explain how to use BulletFactory ? I can not use BindFactory<Bullet, BulletFactory> because BulletFactory is not inherit from PlaceholdFactory?
from zenject.
Related Issues (20)
- ZenjectIntegrationTestFixture.Setup destroys objects that prevent UnityTests from running.
- Link Checker Report
- [Doc Bug] Broken link in Readme.md for example of using multiscene setups
- Failed to remove SceneContext from SceneContextRegistry HOT 1
- Circular Dependencies
- Unused sample zenject scripts in build (IL2CPP and Zenject)
- NullReferenceException when second time inject HOT 1
- working with additive scenes? HOT 1
- i need to declare many signals. is there a solution for that? HOT 1
- [Zenject 6 Upgrade] Not possible to bind multiple interfaces to the same implementation when using WithId anymore?
- There is no DisposableManager.RemoveLate method for removing previously registrated objects.
- Prefab installer ignore bind FromInstance
- Passing dynamic data + prefab through method Create (Factory) while that prefab has GameObjectContext HOT 1
- The type or namespace name 'ConstructorChoiceStrategy' could not be found while building NonUnityBuild solution
- "Re-injecting" dependencies into a prefab when it's spawned from a MemoryPool? HOT 1
- Project Context: "Null Installer" assert hit when using Prefab Variant only on built version
- MemoryPool<Param, Value> with CustomFactory HOT 1
- When using Container.Instantiate to create a new object in the Create method of the factory, IMemoryPool is not assigned.
- [question] Is generic installers possible?
- Inquiry Regarding IDisposable in Zenject
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from zenject.