Comments (3)
Did you measure what impact that has on performance?
from zenject.
Are you saying that we don't need to use this code anymore?
return Resources.FindObjectsOfTypeAll<GameObject>()
.Where(x => x.transform.parent == null
&& x.GetComponent<ProjectContext>() == null
&& x.scene == scene);
That would be great since that's hacky and less performant than scene.GetRootGameObjects. But according to the comment in ZenUtilInternal.GetRootGameObjects, it doesn't work when executed during Awake
from zenject.
@svermeulen Yes exactly. I think this is the issue which is explained in the comment.https://issuetracker.unity3d.com/issues/scene-is-not-considered-loaded-when-awake-is-called
@extrawurst I wasn't remember the original ratios so tested again in our game on 2018.4.10 Editor.
Current method -> 317 KB GC, 3.95 ms
Suggested method -> 0.8 KB GC, 0.01 ms
from zenject.
Related Issues (20)
- Do not Initialize GameObjectContext's kernel until SceneContext is initialized (Disabled AutoRun)
- ZenjectIntegrationTestFixture.Setup destroys objects that prevent UnityTests from running.
- Link Checker Report
- [Doc Bug] Broken link in Readme.md for example of using multiscene setups
- Failed to remove SceneContext from SceneContextRegistry HOT 1
- Circular Dependencies
- Unused sample zenject scripts in build (IL2CPP and Zenject)
- NullReferenceException when second time inject HOT 1
- working with additive scenes? HOT 1
- i need to declare many signals. is there a solution for that? HOT 1
- [Zenject 6 Upgrade] Not possible to bind multiple interfaces to the same implementation when using WithId anymore?
- There is no DisposableManager.RemoveLate method for removing previously registrated objects.
- Prefab installer ignore bind FromInstance
- Passing dynamic data + prefab through method Create (Factory) while that prefab has GameObjectContext HOT 1
- The type or namespace name 'ConstructorChoiceStrategy' could not be found while building NonUnityBuild solution
- "Re-injecting" dependencies into a prefab when it's spawned from a MemoryPool? HOT 1
- Project Context: "Null Installer" assert hit when using Prefab Variant only on built version
- MemoryPool<Param, Value> with CustomFactory HOT 1
- When using Container.Instantiate to create a new object in the Create method of the factory, IMemoryPool is not assigned.
- [question] Is generic installers possible?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from zenject.