Comments (2)
It seems we can't know new_dtypes for columns other than on
in advance. @dchigarev, do you think we should change the logic in _compute_result_metadata
to only compute dtypes for on
or we should completely remove the logic for new_dtypes
computation?
from modin.
It seems we can't know new_dtypes for columns other than on in advance.
I believe in case of a left-merge we can preserve dtypes for 'on' columns and all the columns from the left frame (since the left frame is never reindexed as far as I understand). We can also keep dtypes for the 'object' columns of the right frame, since in this case the column's dtype won't change even if we add NaNs to it.
For an inner merge, it seems that the current logic of dtypes precomputation works just fine (since we don't add NaNs to columns).
from modin.
Related Issues (20)
- Fix ASV after changing default branch: "master" -> "main"
- Recheck that all methods with `numeric_only=True` works correctly
- Implement DataFrame API standard HOT 1
- Update docs on how to enable Modin logs for high-level API and low-level API
- Use custom resources for Ray to schedule a task on a concrete node
- Modin should work correctly with pandas, which uses pyarrow as a backend HOT 1
- BUG: df.melt cannot does not handle duplicate value_vars correctly
- BUG: Falling back to standard Pandas implementation when assigning a dataframe to a columnar selection HOT 1
- Find a way to limit parallelism for tasks running in parallel for different engines
- Update docs as to when Modin operators work best HOT 4
- Update `dataframe-api-compat` version
- Consider remove `use_legacy_dataset=False`
- BUG: Importing `modin.pandas.api.extensions` overwrites re-export of `pandas.api` submodules
- Do `right._modin_frame.combine()` for merge and join only when necessary
- Don't preserve bad partition for `merge`
- Remove Series.dt.to_timestamp HOT 3
- Properties that default to pandas have unclear error messages
- HDK deprecation
- BUG: Series + DataFrame result is different object type depending on order of operands
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from modin.