GithubHelp home page GithubHelp logo

Wrong dtypes after `merge` op about modin HOT 2 OPEN

anmyachev avatar anmyachev commented on May 23, 2024
Wrong dtypes after `merge` op

from modin.

Comments (2)

YarShev avatar YarShev commented on May 23, 2024

It seems we can't know new_dtypes for columns other than on in advance. @dchigarev, do you think we should change the logic in _compute_result_metadata to only compute dtypes for on or we should completely remove the logic for new_dtypes computation?

def _compute_result_metadata(cls, left, right, on, left_on, right_on, suffixes):

from modin.

dchigarev avatar dchigarev commented on May 23, 2024

It seems we can't know new_dtypes for columns other than on in advance.

I believe in case of a left-merge we can preserve dtypes for 'on' columns and all the columns from the left frame (since the left frame is never reindexed as far as I understand). We can also keep dtypes for the 'object' columns of the right frame, since in this case the column's dtype won't change even if we add NaNs to it.

For an inner merge, it seems that the current logic of dtypes precomputation works just fine (since we don't add NaNs to columns).

from modin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.