GithubHelp home page GithubHelp logo

Merging with Tihu about g2p HOT 8 OPEN

b00f avatar b00f commented on May 29, 2024
Merging with Tihu

from g2p.

Comments (8)

mohamad-hasan-sohan-ajini avatar mohamad-hasan-sohan-ajini commented on May 29, 2024 3

Hey @b00f

I genuinely believe that CPPG2P is ready to be used in Tihu project. The src/test.cpp contains a quite descriptive example. Please take a look at it and tell me if something is wrong with that.

Regards

from g2p.

mohamad-hasan-sohan-ajini avatar mohamad-hasan-sohan-ajini commented on May 29, 2024 1

I'll take a look in couple of days.

from g2p.

mohamad-hasan-sohan-ajini avatar mohamad-hasan-sohan-ajini commented on May 29, 2024

Hey @b00f

I'll be glad if I could participate in the Tihu project. It was the reason I started this repo. Would you please tell me what repo should I look? This is the repo I should contribute to or this one?
It's been a long time since the last time I kept in touch with you.

thank in advances

from g2p.

b00f avatar b00f commented on May 29, 2024

@Hajix

Look at this line

Here we use g2p as interactive python app. I think you may change this file to use your library in intractive mode or better if you can make it non-interactive mode. @ebraminio maybe can help us on this matter.

I checked today, you are part of developer team in Tihu, therefor you have write access to all repositories under TihuNLP

from g2p.

b00f avatar b00f commented on May 29, 2024

Please don't hesitate to contact me if you need help.

from g2p.

mohamad-hasan-sohan-ajini avatar mohamad-hasan-sohan-ajini commented on May 29, 2024

Hey b00f

I take a look at the line you mentioned. I think it's easier (and more beneficial) to implement a G2P class in C++, rather than opening PIPE and interact with a an executive process. So I opened this repo for this purpose. I thinks it'll take me about two weeks to complete.

from g2p.

b00f avatar b00f commented on May 29, 2024

@Hajix, you are right. This approach is much better.
Soon we can make it. I am so excited about it.

from g2p.

b00f avatar b00f commented on May 29, 2024

@Hajix

It looks perfect. I suggest to create a separate test folder next to src.

Right now we can merge the code.

from g2p.

Related Issues (3)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.