GithubHelp home page GithubHelp logo

Comments (6)

kamtschatka avatar kamtschatka commented on June 13, 2024

Yeah I tried it out and it works fine, but I can't figure out how to make the screenshot show up correctly.
Tried all kinds of things with ScreenshotSection.tsx, but the screenshot stays like this:
image

If I remove the "height: 100%" style from the create image tag it looks fine, but I don't understand how that works with the "Image" tag from next:
image

from hoarder-app.

scubanarc avatar scubanarc commented on June 13, 2024

I didn't look at the source, but it seems like some sort of height-limited div with "overflow:hidden" might to do the trick.

from hoarder-app.

MohamedBassem avatar MohamedBassem commented on June 13, 2024

Yeah, dealing with the Image tag of next can be very annoying :) I'll check it over the weekend.

I think also I'll also make this behavior configurable. Screenshots can take a ton of disk space specially with that size and not everyone finds them useful.

from hoarder-app.

kamtschatka avatar kamtschatka commented on June 13, 2024

I found the solution here and opened a PR.
You mentioned making that configurable. You mean with an environment variable or in the UI?

from hoarder-app.

MohamedBassem avatar MohamedBassem commented on June 13, 2024

Nice! will check it out!

By configurable, I mean with an env variable. All config knobs are here: https://github.com/MohamedBassem/hoarder-app/blob/main/packages/shared/config.ts and you'll find this serverConfig option used a lot in the crawlerWorker.ts already. And if it's not too much, I'd be grateful if you add the new env variable to the docs here as well https://github.com/MohamedBassem/hoarder-app/blob/main/docs/docs/03-configuration.md :) I think we can name it CRAWLER_FULL_PAGE_SCREENSHOT.

from hoarder-app.

MohamedBassem avatar MohamedBassem commented on June 13, 2024

@kamtschatka implemented in #148!

from hoarder-app.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.