Comments (6)
Yeah I tried it out and it works fine, but I can't figure out how to make the screenshot show up correctly.
Tried all kinds of things with ScreenshotSection.tsx, but the screenshot stays like this:
If I remove the "height: 100%" style from the create image tag it looks fine, but I don't understand how that works with the "Image" tag from next:
from hoarder-app.
I didn't look at the source, but it seems like some sort of height-limited div with "overflow:hidden" might to do the trick.
from hoarder-app.
Yeah, dealing with the Image
tag of next can be very annoying :) I'll check it over the weekend.
I think also I'll also make this behavior configurable. Screenshots can take a ton of disk space specially with that size and not everyone finds them useful.
from hoarder-app.
I found the solution here and opened a PR.
You mentioned making that configurable. You mean with an environment variable or in the UI?
from hoarder-app.
Nice! will check it out!
By configurable, I mean with an env variable. All config knobs are here: https://github.com/MohamedBassem/hoarder-app/blob/main/packages/shared/config.ts and you'll find this serverConfig
option used a lot in the crawlerWorker.ts
already. And if it's not too much, I'd be grateful if you add the new env variable to the docs here as well https://github.com/MohamedBassem/hoarder-app/blob/main/docs/docs/03-configuration.md :) I think we can name it CRAWLER_FULL_PAGE_SCREENSHOT
.
from hoarder-app.
@kamtschatka implemented in #148!
from hoarder-app.
Related Issues (20)
- How to verify hoarder app is working with the local ollama HOT 4
- Crawling job failed: ProtocolError: Protocol error (Page.captureScreenshot): Unable to capture screenshot HOT 3
- Feature request: Browser extension "Open your Hoarder saves" HOT 1
- Long description meta tag causes invalid yaml to be produced HOT 1
- Text that contains single and double quotes produces invalid YAML HOT 1
- Too long lines are truncated which produces invalid YAML HOT 2
- [Crawler] Failed to connect to the browser instance, will retry in 5 secs HOT 2
- Any plans to support copy to clipboard (markdown code) for notes? HOT 10
- Failed to fetch link content ... HOT 3
- [Feature Request] Share specific notes publicly HOT 1
- First time user notes HOT 5
- Do you plan to allow this to consume RSS feeds? HOT 3
- Feature request: possibility to paste image into a note HOT 1
- Feature request: Import markdown note HOT 1
- re-index of database is not scanning all places when bookmark tags are changed. Manual indexing is working as workaround
- Improve the CLI
- Allow downloading more content from a webpage and index it
- npm error HOT 2
- Crawler aint crawling [Error when performing the request to....] HOT 1
- feature requests HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hoarder-app.