Comments (6)
I'm pretty sure you don't even need to ask for any permissions to reorder the tabs.
From https://developer.chrome.com/extensions/tabs:
The majority of the chrome.tabs API can be used without declaring any permission. However, the "tabs" permission is required in order to populate the url, title, and favIconUrl properties of Tab.
from rearrange-tabs.
@rsynnest Thank you for the kind words 👍
I will review the permissions and see why the tabs
permission is required. IIRC the tabs
permission includes the access to all the tabs and how they're laid out. I remember another permission called activeTab
, but, I can't remember if that was sufficient to handle the rearrangement of tabs. However, I will review the permissions and see if there's a "simpler" permission available, that can be used to implement the tab rearrangement functionality. There's absolutely no need to request more permissions than the ones necessary. If I find another permission that works with this use case, I will update the extension with that. Thanks for bringing this up.
from rearrange-tabs.
@mohnish I have this running successfully (tested highlighted, pinnned, and regular tabs) by simply changing the permission "tabs" to "activeTab". No other code change required! With this change the permission message to the user is "this extension requires no special permissions".
from rearrange-tabs.
@LGabAnnell you are correct, no permissions are needed to reorder tabs. You can remove the permission block entirely from manifest.json and the extension is still 100% functional. PR submitted
from rearrange-tabs.
Hey @rsynnest, thank you for the PR. I'm sorry I was out of town attending a family emergency. I will take a look at it tomorrow. Appreciate your work.
@LGabAnnell thanks and appreciate your input on this one.
from rearrange-tabs.
Fixed this in #20
from rearrange-tabs.
Related Issues (20)
- Look into extension conversion for Safari HOT 1
- Upgrade to Manifest v3 HOT 4
- Feature Request: Make shortcuts configurable HOT 4
- Include info about configuring shortcut keys HOT 5
- New tabs move when trying to select text HOT 1
- Add a shortcut to handle tabs group HOT 1
- option-shift-left / right move tab even when overridden HOT 3
- Allow more symbols in custom shortcuts HOT 1
- Guidance to macOS user? HOT 1
- For some reason, Google Chrome has frequent crashes when this plugin is enabled HOT 8
- Note to the community
- Wrong shortcut from the address bar HOT 1
- 3.0 issues for Linux users HOT 5
- Move selected tab circular manner with 15 feb update HOT 4
- Investigate extension functionality in other browsers HOT 3
- After 3.0.0 - stopped working in linux HOT 1
- compatibility with Arc HOT 1
- Wraparound tabs stopped working after 3.0.0 HOT 3
- Feature Request: Add Pin Tab Functionality 📌 HOT 4
- Tabs no longer wrap to beginning when at the end position HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rearrange-tabs.