In memory sliding window seems to be not honouring the limits about ratelimitj

[dheerajjoshim]

This appears to be working just fine in the Redis environment

import java.time.Duration;
import java.time.temporal.ChronoUnit;
import java.util.Collections;
import java.util.Set;

import org.junit.Rule;
import org.junit.Test;
import org.testcontainers.containers.GenericContainer;

import es.moki.ratelimitj.core.limiter.request.RequestLimitRule;
import es.moki.ratelimitj.core.limiter.request.RequestRateLimiter;
import es.moki.ratelimitj.redis.request.RedisRateLimiterFactory;
import io.lettuce.core.RedisClient;

public class RedisTest {

    @Rule
    public GenericContainer<?> redis = new GenericContainer<>("redis:3.0.6").withExposedPorts(6379);

    @Test
    public void test() {
        final RedisRateLimiterFactory factory =
                new RedisRateLimiterFactory(
                        RedisClient.create("redis://" + redis.getContainerIpAddress() + ":"
                                + redis.getMappedPort(6379)));

        final Duration precisionDuration = Duration.of(1, ChronoUnit.SECONDS);

        final Set<RequestLimitRule> rules =
                Collections.singleton(RequestLimitRule.of(Duration.ofSeconds(10), 1)
                        .withPrecision(precisionDuration));
        final RequestRateLimiter requestRateLimiter = factory.getInstance(rules);

        while (true) {
            final UserObject user =
                    UserObject.builder().age(11).name("ABC").address("NewYork").build();
            processStudent(user, requestRateLimiter);
        }

    }

    private static void processStudent(final UserObject user,
            final RequestRateLimiter addressRuleRateLimiter) {
        if (!addressRuleRateLimiter.overLimitWhenIncremented(user.getAddress())) {
            user.callStudent();
        }
    }
}

Output

10 Mar 2020 17:00:36  UserObject(name=ABC, age=11, address=NewYork, isProcessed=false)
10 Mar 2020 17:00:46  UserObject(name=ABC, age=11, address=NewYork, isProcessed=false)
10 Mar 2020 17:00:56  UserObject(name=ABC, age=11, address=NewYork, isProcessed=false)
10 Mar 2020 17:01:06  UserObject(name=ABC, age=11, address=NewYork, isProcessed=false)
10 Mar 2020 17:01:16  UserObject(name=ABC, age=11, address=NewYork, isProcessed=false)

Used TestContainer to validate