namespace about moment

[timrwood]

Yeah, that's what I had done originally, but in order to use _.mixin, you can only have a single level of hierarchy of the functions you pass in.

I did notice that I had to prefix and suffix a lot of the functions, so it may make more sense to create a _.date() object that I prototype the other functions onto.

So, _.formatDate() would become _.date().format() and _.fromNow() would become _.date().fromNow().

I'll make a branch and try it out.

[timrwood]

Alright, here's a stab at cleaning up the _ namespace.

https://github.com/timrwood/underscore.date/blob/namespace/lib/underscore.date.js

So now, there would only be _.date(), _.now(), and _.isLeapYear(yearnumber). Everything else would be called on a _.date() variable like

_.date([2010, 0, 31]).add({M:1}).format("MMMM Do YYYY");
or
_([2010, 0, 31]).date().add({M:1}).format("MMMM Do YYYY");

instead of

_([2010, 0, 31]).chain().date().addTime({M:1}).formatDate("MMMM Do YYYY").value()

Also, I was able to strip out all the suffixes, so the _.date() prototype functions are now format(string), add(object), subtract(object), customize(object), from(dateInput, boolean), fromNow(boolean), isLeapYear(), and relative(number).

[dvv]

Neat! In addition, what if upgrade _.isLeapYear(yearnumber) to take Date also? This would 1) improve usability (no need to snoop explicitly for getYear) and 2) allow to move it under _.date() ;)

[timrwood]

There are 2 instances of isLeapYear.
_.isLeapYear(number) and _.date().isLeapYear().

_.isLeapYear(number) takes a year number (eg. 2010) and returns true if that year is a leap year.

_.date().isLeapYear() basically maps to _.isLeapYear(this.date.getFullYear()), using the date's year.

I figured it might be useful to check if a year is a leap year without creating a date object.

[timrwood]

Pushed to master. Closing.

[dvv]

Thanks! Soon will be heavily exploiting this lib ;)