GithubHelp home page GithubHelp logo

Comments (6)

pedaars avatar pedaars commented on September 26, 2024

I would like to take this please

from vibe-storybook-components.

SergeyRoyt avatar SergeyRoyt commented on September 26, 2024

Thanks, @pedaars! It's yours
Good luck with that!
Feel free to ask any questions if needed :)

from vibe-storybook-components.

pedaars avatar pedaars commented on September 26, 2024

@SergeyRoyt Well that was interesting I think I have it working using a new addon released for v7 of storybook but I need a component story that is available in both this storybook and https://style.monday.com/?path=/story/welcome--page so I can compare.

Is anyone working on any?

from vibe-storybook-components.

SergeyRoyt avatar SergeyRoyt commented on September 26, 2024

@SergeyRoyt Well that was interesting I think I have it working using a new addon released for v7 of storybook but I need a component story that is available in both this storybook and https://style.monday.com/?path=/story/welcome--page so I can compare.

Is anyone working on any?

Hey @pedaars !
Let's try to compare e.g. Tip component from vibe-storybook-components and AttentionBox from monday-ui-react-core - https://style.monday.com/?path=/story/feedback-attentionbox--states. It's not 100% exactly the same component, but in terms of colors should behave the same
Here is how it should look e.g. in a Dark theme
image

For test I've applied dark-app-theme in vibe-storybook-components storybook to the outer div, here is what I've achieved
image
Colors doesn't look too good, but good news they've changed - so you should get smth similar if the theme-switcher is working fine

from vibe-storybook-components.

pedaars avatar pedaars commented on September 26, 2024

Thanks for that. Ok so my solution is working and I have raised a pr

from vibe-storybook-components.

SergeyRoyt avatar SergeyRoyt commented on September 26, 2024

Closed thanks to @pedaars!

from vibe-storybook-components.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.