GithubHelp home page GithubHelp logo

Comments (10)

shaharzil avatar shaharzil commented on June 29, 2024 3

Hi @ahlivehr and thank you for bringing this bug to our attention :)

Thank you @HermanBide , We would appreciate it if you could contribute to fixing the problem. I'll just mention that since the fix may be a breaking change, we may not be able to merge it right now and can only include it in our next major version

from vibe.

ahlivehr avatar ahlivehr commented on June 29, 2024

The specific place in the source code where the issue comes from is:
https://github.com/mondaycom/monday-ui-react-core/blob/c057a2e83d2d3fb62c05e29ab768f44a77045fe9/packages/core/src/components/Tipseen/Tipseen.tsx#L146

Notice how the element is "p", but if you put a TipseenContent element inside of it, there will be a div inside of a p tag.

from vibe.

HermanBide avatar HermanBide commented on June 29, 2024

has this been fixed ?

from vibe.

ahlivehr avatar ahlivehr commented on June 29, 2024

@HermanBide I don't think it has. I just filed this bug yesterday.

from vibe.

HermanBide avatar HermanBide commented on June 29, 2024

can i contribute to fixing this bug ?

from vibe.

ahlivehr avatar ahlivehr commented on June 29, 2024

@shaharzil No problem! Do you happen to know roughly when the next major version will be released? I really appreciate everyone's continuous contributions to this repo.

from vibe.

HermanBide avatar HermanBide commented on June 29, 2024

awesome please assign this to me ill work on it asap

from vibe.

HermanBide avatar HermanBide commented on June 29, 2024

the bug error doesnt show in the console anymore. here is what i did ->
I removed the div inside Tipseen since a 'p' element could not nest a 'div' and instead placed the Tipseen inside the div in component "tipseen.stories.js" which stopped the error.

   <div className="monday-storybook-tipseen_container">
          <Tipseen
            modifiers={modifiers}
            position={Tipseen.positions.RIGHT}
            content={
              <TipseenContent title="This is a title" hideDismiss>
                Popover message will appear here loremipsum dolor samet…
              </TipseenContent>
            }
          />
        </div>

please try this instead and let me know if you are still getting the same error. also there seem to be a bug about id in Tipseen.tsx

from vibe.

HermanBide avatar HermanBide commented on June 29, 2024

let me know if you also need help with the other bug

react-jsx-runtime.development.js:124 Warning: Invalid prop id supplied to React.Fragment. React.Fragment can only have key and children props.

from vibe.

HermanBide avatar HermanBide commented on June 29, 2024

what component ->folder/file is this code in so that i can fix it?

from vibe.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.