Comments (10)
Hi @ahlivehr and thank you for bringing this bug to our attention :)
Thank you @HermanBide , We would appreciate it if you could contribute to fixing the problem. I'll just mention that since the fix may be a breaking change, we may not be able to merge it right now and can only include it in our next major version
from vibe.
The specific place in the source code where the issue comes from is:
https://github.com/mondaycom/monday-ui-react-core/blob/c057a2e83d2d3fb62c05e29ab768f44a77045fe9/packages/core/src/components/Tipseen/Tipseen.tsx#L146
Notice how the element is "p", but if you put a TipseenContent element inside of it, there will be a div inside of a p tag.
from vibe.
has this been fixed ?
from vibe.
@HermanBide I don't think it has. I just filed this bug yesterday.
from vibe.
can i contribute to fixing this bug ?
from vibe.
@shaharzil No problem! Do you happen to know roughly when the next major version will be released? I really appreciate everyone's continuous contributions to this repo.
from vibe.
awesome please assign this to me ill work on it asap
from vibe.
the bug error doesnt show in the console anymore. here is what i did ->
I removed the div inside Tipseen since a 'p' element could not nest a 'div' and instead placed the Tipseen inside the div in component "tipseen.stories.js" which stopped the error.
<div className="monday-storybook-tipseen_container">
<Tipseen
modifiers={modifiers}
position={Tipseen.positions.RIGHT}
content={
<TipseenContent title="This is a title" hideDismiss>
Popover message will appear here loremipsum dolor samet…
</TipseenContent>
}
/>
</div>
please try this instead and let me know if you are still getting the same error. also there seem to be a bug about id in Tipseen.tsx
from vibe.
let me know if you also need help with the other bug
react-jsx-runtime.development.js:124 Warning: Invalid prop id
supplied to React.Fragment
. React.Fragment can only have key
and children
props.
from vibe.
what component ->folder/file is this code in so that i can fix it?
from vibe.
Related Issues (20)
- <Flex> - add BASELINE for the `align` prop HOT 1
- [Bug]: Tabs - line of active tab is under expected position HOT 2
- [Bug]: Editable heading type is not taken HOT 9
- [Bug]: MultiStepIndicator styling problems HOT 7
- [Bug]: Dialogs inside Modal are not clickable HOT 3
- [Feat] ListItemAvatar - Be able to provide all Avatar props HOT 3
- [Feat]: ModalFooterButtons - be able to disable primary button
- [Feat]: ModalFooterButtons - be able to show/hide secondary button
- [Bug]: Dropdown with multiselect and size small has several issues HOT 2
- [Type]: change "icon" prop type to SubIcon in ModalHeader and Tab HOT 3
- [Bug]: hideCloseButton in modal - not working HOT 3
- [Bug]: multiple issues with dropdown HOT 1
- [Bug]: DatePicker | no null protection for onPickDate callback HOT 1
- [Bug]: Dropdown virtualized menu - wrong height calculation
- [Types]: Typography - change tooltipProps type to Partial<TooltipProps> HOT 1
- [Types]: Avatar - change tooltipProps type to Partial<TooltipProps> HOT 1
- [Refactor] AlertBanner - replace Button + Icon with IconButton HOT 1
- [Feat] `onClear` attribute for the `Search` component HOT 1
- [Bug]: Dropdown font is broken
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from vibe.