Comments (5)
@vivek32ta Sure :) Let's do this. I'll check your PR when it's ready.
from vibe.
Hi @hadasfa, I'd love to take this up
from vibe.
@vivek32ta do you still working on this PR?
from vibe.
@hadasfa Yes yes. I am. I was just confused a bit with the codebase. This is the first time I'm working on a UI package. Sorry, please excuse me for the delay. I was stuck if I have to add the role in just Combobox component or add it to its child components as well, like Search and TextArea, because there is no role attribute in the props passed.
from vibe.
Combo box component renders a Search input which has a default role value search
.
Do we need to customize the Search prop structure to give the required role in Combo box?
from vibe.
Related Issues (20)
- [Feat]: ModalFooterButtons - be able to disable primary button
- [Feat]: ModalFooterButtons - be able to show/hide secondary button
- [Bug]: Dropdown with multiselect and size small has several issues HOT 2
- [Type]: change "icon" prop type to SubIcon in ModalHeader and Tab HOT 3
- [Bug]: hideCloseButton in modal - not working HOT 3
- [Bug]: multiple issues with dropdown HOT 1
- [Bug]: DatePicker | no null protection for onPickDate callback HOT 1
- [Bug]: Dropdown virtualized menu - wrong height calculation HOT 1
- [Types]: Typography - change tooltipProps type to Partial<TooltipProps> HOT 1
- [Types]: Avatar - change tooltipProps type to Partial<TooltipProps> HOT 1
- [Refactor] AlertBanner - replace Button + Icon with IconButton HOT 1
- [Feat] `onClear` attribute for the `Search` component HOT 2
- [Bug]: Dropdown font is broken
- [Docs]: convert Menu.stories.js to TS HOT 3
- [Docs]: convert AlertBanner.stories.js to TS HOT 4
- [Docs]: convert AvatarGroup.stories.js to TS
- [Docs]: convert Skeleton.stories.js to TS HOT 1
- [Bug]: Tooltip component is flickering HOT 1
- [Bug]: Combobox - when there are no items there is a redundant spacing below the search input
- [Bug]: Warning Toast Type renders nothing HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from vibe.