GithubHelp home page GithubHelp logo

Comments (5)

hadasfa avatar hadasfa commented on September 26, 2024 1

@vivek32ta Sure :) Let's do this. I'll check your PR when it's ready.

from vibe.

vivek32ta avatar vivek32ta commented on September 26, 2024

Hi @hadasfa, I'd love to take this up

from vibe.

hadasfa avatar hadasfa commented on September 26, 2024

@vivek32ta do you still working on this PR?

from vibe.

vivek32ta avatar vivek32ta commented on September 26, 2024

@hadasfa Yes yes. I am. I was just confused a bit with the codebase. This is the first time I'm working on a UI package. Sorry, please excuse me for the delay. I was stuck if I have to add the role in just Combobox component or add it to its child components as well, like Search and TextArea, because there is no role attribute in the props passed.

from vibe.

aayushbisen avatar aayushbisen commented on September 26, 2024

Combo box component renders a Search input which has a default role value search.

Do we need to customize the Search prop structure to give the required role in Combo box?

from vibe.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.