Comments (16)
Hi @kabhamo ,
Thanks! going over the PR now
from vibe.
Hey @orrgottlieb it would be great if you assign this issue to me
from vibe.
@Rahul-Palahwat go for it!
from vibe.
Hey @Rahul-Palahwat ! Are you still working on this issue?
from vibe.
Hey @hadasfa so sorry for delay. Please assign this issue to anyone else
from vibe.
Hey @orrgottlieb can I pick this up?
from vibe.
@suvnshr You got this! Good luck 🥇
from vibe.
Thanks @hadasfa
from vibe.
@suvnshr Hey are you still working on this issue?
from vibe.
yes, got a busy schedule as of today...will start working on it again tomorrow onwards.
I have some changes left still.
from vibe.
@orrgottlieb I have a doubt
Here, isFirefox
is imported from user-agent-utils, where it is defined as a simple function.
but isFireFox
is also calling a jest function in the same file here.
I'm confused, what type I should assign to isFireFox
?
are they supposed to be 2 different variables? one for calling the jest function, and one for that user-agent function?
from vibe.
Hi @orrgottlieb, @hadasfa,
I hope you are doing well.
I noticed that useSupportFirefoxLabelClick.jsx
is still not converted to typescript.
I have a PR ready to be created with relevant changes for the useSupportFirefoxLabelClick hook file
Also, I have tested the functionality and it works as needed, I would be so happy to create a PR for it.
Let me know if it is still relevant.
from vibe.
is it still opened?
from vibe.
Hi @lidoravitan, this is done, but we have another great option for you if you want ResponsiveList
https://github.com/mondaycom/monday-ui-react-core/blob/master/src/components/ResponsiveList/ResponsiveList.jsx
if you want i can create an issue for you and assign it to you ?
from vibe.
sure let me know what needs to be done on ResponsiveList
from vibe.
@orrgottlieb any update?
from vibe.
Related Issues (20)
- [Feat]: ModalFooterButtons - be able to disable primary button
- [Feat]: ModalFooterButtons - be able to show/hide secondary button
- [Bug]: Dropdown with multiselect and size small has several issues HOT 2
- [Type]: change "icon" prop type to SubIcon in ModalHeader and Tab HOT 3
- [Bug]: hideCloseButton in modal - not working HOT 3
- [Bug]: multiple issues with dropdown HOT 1
- [Bug]: DatePicker | no null protection for onPickDate callback HOT 1
- [Bug]: Dropdown virtualized menu - wrong height calculation HOT 1
- [Types]: Typography - change tooltipProps type to Partial<TooltipProps> HOT 1
- [Types]: Avatar - change tooltipProps type to Partial<TooltipProps> HOT 1
- [Refactor] AlertBanner - replace Button + Icon with IconButton HOT 1
- [Feat] `onClear` attribute for the `Search` component HOT 2
- [Bug]: Dropdown font is broken
- [Docs]: convert Menu.stories.js to TS HOT 3
- [Docs]: convert AlertBanner.stories.js to TS HOT 4
- [Docs]: convert AvatarGroup.stories.js to TS
- [Docs]: convert Skeleton.stories.js to TS HOT 1
- [Bug]: Tooltip component is flickering HOT 1
- [Bug]: Combobox - when there are no items there is a redundant spacing below the search input
- [Bug]: Warning Toast Type renders nothing HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from vibe.