Comments (5)
This actually seems to be a bug in our serde impl. The versions
field uses #[serde(flatten)]
but it doesn't flatten when serializing. Need to figure out why.
I don't really want to support 2 ways of configuring the versions though.
from proto.
Figured out the serde problem
from proto.
Need to figure out why.
We have two flatten
fields, one of them with #[serde(skip_serializing)]
and I'm guessing that's the why.
proto/crates/core/src/proto_config.rs
Lines 98 to 103 in 7bf0abc
Maybe we should have a custom deserializer for the unknown
field to update the versions
property instead of massaging the struct after deserialization.
Possibly related? serde-rs/serde#1504
from proto.
The bug part of this is fixed :-). If you think it's not worth changing the toml
, you can of course close this issue.
from proto.
Looked into this a bit and it made it rather difficult to support both patterns.
from proto.
Related Issues (20)
- Proto removes comments when it modifies TOML files HOT 1
- Feature request: Allow snake_case for plugin ids HOT 5
- Proto Node.js can't execute `corepack` HOT 4
- Feature request: Pinning TOML plugins HOT 4
- Feature request: Plugin checksums HOT 6
- Feature request: Custom locators HOT 3
- Windows: proto uses `\n` when editing `$profile` (should be `\r\n`)
- Improve error message when xz is not installed in the system HOT 4
- version_suffix is no longer respected for VersionSpec::Alias
- proto install pnpm doesn't work HOT 10
- What would you like to see in proto? HOT 9
- `proto outdated` shows misleading error when it fails to resolve version HOT 14
- proto outdated --update clobbers non-version settings HOT 1
- proto use command causes error HOT 1
- [Windows] "proto regen [--bin]" always throws the error "proto::tool::invalid_dir" HOT 9
- Inventory directory error in all *but* Home dir (Debian) HOT 6
- Feature Request: Profile or Environments to e.g. only install some tools in CI HOT 3
- Plugin Removal Leaves Config Entries Intact HOT 2
- Inhancement of node.js version detections HOT 1
- missing_binary error when proto and proto-shim installed in /usr/bin HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from proto.