GithubHelp home page GithubHelp logo

Comments (5)

milesj avatar milesj commented on June 2, 2024 1

This actually seems to be a bug in our serde impl. The versions field uses #[serde(flatten)] but it doesn't flatten when serializing. Need to figure out why.

I don't really want to support 2 ways of configuring the versions though.

from proto.

milesj avatar milesj commented on June 2, 2024 1

Figured out the serde problem

from proto.

rotu avatar rotu commented on June 2, 2024

Need to figure out why.

We have two flatten fields, one of them with #[serde(skip_serializing)] and I'm guessing that's the why.

#[setting(flatten, merge = merge::merge_btreemap)]
pub versions: BTreeMap<Id, UnresolvedVersionSpec>,
#[setting(flatten, merge = merge::merge_btreemap)]
#[serde(skip_serializing)]
pub unknown: BTreeMap<String, TomlValue>,

Maybe we should have a custom deserializer for the unknown field to update the versions property instead of massaging the struct after deserialization.

Possibly related? serde-rs/serde#1504

from proto.

rotu avatar rotu commented on June 2, 2024

The bug part of this is fixed :-). If you think it's not worth changing the toml, you can of course close this issue.

from proto.

milesj avatar milesj commented on June 2, 2024

Looked into this a bit and it made it rather difficult to support both patterns.

from proto.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.