GithubHelp home page GithubHelp logo

Comments (18)

MordechaiHadad avatar MordechaiHadad commented on July 3, 2024 1

I'll setup those just for the sake of learning and future projects, ig,

from bob.

MordechaiHadad avatar MordechaiHadad commented on July 3, 2024 1

🤔 so how should i go about doing this, since i dont really have access to getting those hashes from a formula

I'm pretty sure brew bump-formulae <url> will attempt to auto-determine the sha256 (which is the only one you need) of the given URL. So for example, you might call it from within a github action after the release has been published, at which point you could pass the URL of the newly-tagged release's .tar.gz. Then (within the workflow) brew bump-formulae would presumably download that .tar.gz, calculate the sha256 for you, then auto-commit and make the pull request to homebrew-core for you (i'm a bit fuzzy on the last step as i've never done it myself)

Oh this is cool

from bob.

MordechaiHadad avatar MordechaiHadad commented on July 3, 2024 1

@Amar1729 review #167 if it seems fine to you

from bob.

MordechaiHadad avatar MordechaiHadad commented on July 3, 2024 1

Oh shit epic contributors, I'd still try the other bump formula next release.

from bob.

MordechaiHadad avatar MordechaiHadad commented on July 3, 2024

Oh that's cool, tbh I didn't even bother with GH releases maybe I should now

from bob.

Amar1729 avatar Amar1729 commented on July 3, 2024

FWIW i think homebrew generally prefers to install things from Github releases, so could be good to at least push tags for releases.

As far as the CI, might not actually be worth it to you to automate the whole thing if releases are relatively infrequent (relevant xkcd)

from bob.

MordechaiHadad avatar MordechaiHadad commented on July 3, 2024

🤔 so how should i go about doing this, since i dont really have access to getting those hashes from a formula

from bob.

Amar1729 avatar Amar1729 commented on July 3, 2024

🤔 so how should i go about doing this, since i dont really have access to getting those hashes from a formula

I'm pretty sure brew bump-formulae <url> will attempt to auto-determine the sha256 (which is the only one you need) of the given URL. So for example, you might call it from within a github action after the release has been published, at which point you could pass the URL of the newly-tagged release's .tar.gz. Then (within the workflow) brew bump-formulae would presumably download that .tar.gz, calculate the sha256 for you, then auto-commit and make the pull request to homebrew-core for you (i'm a bit fuzzy on the last step as i've never done it myself)

from bob.

MordechaiHadad avatar MordechaiHadad commented on July 3, 2024

What exactly is this part in bump-formulae:

    formulae: |
      FORMULA-1
      FORMULA-2
      FORMULA-3

from bob.

Amar1729 avatar Amar1729 commented on July 3, 2024

That's a constraint on which specific formulae to bump. so you could write just bob

from bob.

MordechaiHadad avatar MordechaiHadad commented on July 3, 2024

so just:

formulae: bob

?

from bob.

MordechaiHadad avatar MordechaiHadad commented on July 3, 2024

@Amar1729 So basically all i have to put in this is just:

- name: Bump formulae
  uses: Homebrew/actions/bump-formulae@master
  with:
    # Custom GitHub access token with only the 'public_repo' scope enabled
    token: ${{secrets.TOKEN}}
    # Bump only these formulae if outdated
    formulae: bob

This is either too easy or the docs kinda suck

from bob.

Amar1729 avatar Amar1729 commented on July 3, 2024

@MordechaiHadad lol, I think so? but you'll also want a thing right before that that creates the release of you didn't do that already

from bob.

MordechaiHadad avatar MordechaiHadad commented on July 3, 2024

@MordechaiHadad lol, I think so? but you'll also want a thing right before that that creates the release of you didn't do that already

Ye working on that, want to make sure the release CD I am gonna make is sync so first it uploads release and then it runs the bump formulae thing

from bob.

MordechaiHadad avatar MordechaiHadad commented on July 3, 2024

https://github.com/MordechaiHadad/bob/actions/runs/6995199206/job/19029858968
Currently its already past 10 minutes 🤣

from bob.

MordechaiHadad avatar MordechaiHadad commented on July 3, 2024

2 hours now jesus

from bob.

Amar1729 avatar Amar1729 commented on July 3, 2024

Huh ... well that's not good, lmao

from bob.

Amar1729 avatar Amar1729 commented on July 3, 2024

Alternatively, could remove the homebrew step; the maintainers + top contributors to homebrew-core are usually pretty quick about updating the formulae in core already Homebrew/homebrew-core#155610

from bob.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.