GithubHelp home page GithubHelp logo

dump文件多余(.)逗号. about holmes HOT 7 CLOSED

AtlanCI avatar AtlanCI commented on August 26, 2024
dump文件多余(.)逗号.

from holmes.

Comments (7)

doujiang24 avatar doujiang24 commented on August 26, 2024

这里没有特别的含义,也不是让用户指定呢

这个 .. 中间应该是 event id,比如 gcheap profile 这样的:h.writeProfileDataToFile(buf, thread, eventID)
只是 cpu 这种的,event id 是空字符串,""
也可以优化一下的,把这里的 .. 改为一个 .
你有兴趣提个 PR 不?应该改动也不大

from holmes.

AtlanCI avatar AtlanCI commented on August 26, 2024

好的 我尝试一下。 要不要为何和其他接口一致把这里也改成eventID? 我在用的时候其他的接口生成的也是..没有eventId的内容。eventID 好像没有暴露给用户。(这好像是一个问题)

1653288574786_3F297B29-8F0A-4f56-AB1D-9608D4B0D0A8

from holmes.

doujiang24 avatar doujiang24 commented on August 26, 2024

👍🏻

event ID 只是因为 gcheap 需要两个 profile,做前后 diff
对于,其他类型,event ID 确实没啥意义

另,在 reporter 接口里,是有暴露 event ID 的

from holmes.

AtlanCI avatar AtlanCI commented on August 26, 2024

我看到了在提供http报告的地方 有暴露接口。 我将尝试提一个PR以修改CPU,MEM,Gourtinedump文件的..

from holmes.

AtlanCI avatar AtlanCI commented on August 26, 2024

#100 我提交了一个PR 我发现evntID在dump文件路径是全局传递的,不太好改。 所以我在底层直接改了文件名的格式

from holmes.

doujiang24 avatar doujiang24 commented on August 26, 2024

@AtlanCI 这是合适的改法,已经合并了,感谢~

from holmes.

AtlanCI avatar AtlanCI commented on August 26, 2024

客气啦 也没做啥 也感谢您 我将关闭这个issue

from holmes.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.