GithubHelp home page GithubHelp logo

Component Observer may continue triggering outputs if the last component triggered a finish during UFlowNode_ComponentObserver::StartObserving about flowgraph HOT 3 CLOSED

PartlyAtomic avatar PartlyAtomic commented on June 12, 2024 1
Component Observer may continue triggering outputs if the last component triggered a finish during UFlowNode_ComponentObserver::StartObserving

from flowgraph.

Comments (3)

MothDoctor avatar MothDoctor commented on June 12, 2024

Hey @lfowles If I understand the issue correctly, the rest of UFlowNode_ComponentObserver::StartObserving() would be executed after the loop, so only binding to Flow Subystem methods?

If so, we shouldn't call ObserveActor in every case, as we would end up with a different issue which... we got plumbed back in August.

Shouldn't we have an additional check to prevent binding to delegates?
This is my proposed fix, what do you think?
423f293

from flowgraph.

PartlyAtomic avatar PartlyAtomic commented on June 12, 2024

This would also work, it's just constructed oddly with different return paths depending on which component triggers finish. If any of the 1..N-1 observed actors trigger a finish it'll return from the loop of registered components. Only if the Nth actor triggers a finish will it hit the branch you added.

from flowgraph.

MothDoctor avatar MothDoctor commented on June 12, 2024

This would also work, it's just constructed oddly with different return paths depending on which component triggers finish. If any of the 1..N-1 observed actors trigger a finish it'll return from the loop of registered components. Only if the Nth actor triggers a finish will it hit the branch you added.

Yes, the main benefit here, was supposed to be avoiding calling ObserveActor prior to checking a node state. But now I realize it was pointless, as we need at least one ObserveActor check to make this node inactive. I'm taking your change in, with a proper note in the release notes. Thanks! :)

from flowgraph.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.