GithubHelp home page GithubHelp logo

Comments (3)

rhaschke avatar rhaschke commented on September 12, 2024 1

Do you see anything I am missing?

I see exactly the regression I described: In MoveIt1 it works, it MoveIt2 it fails as described.
If there are no code changes in the adapter itself, which would explain the interpolation to the new state, maybe time parameterization applies (now) to the whole trajectory (including both, the initial state and the added no-collision waypoint) and adds more waypoints in between? Maybe such kind of interpolation was added there?
I don't have the time to dig into this issue and I don't have an overview of changes applied to MoveIt2. That's why I just reported the issue.

from moveit2.

sjahr avatar sjahr commented on September 12, 2024

Thanks for reporting this issue! At a first glance I don't see any regression between moveit1 and moveit2 in the FixStartStateCollision adapter on the Humble branch. Do you see anything I am missing?

In main I replaced the FixStartState adapter in #2429 with a simple CheckStartStateCollision adapter. My rationale is that an adapter that introduces small jumps is un-intuitive and might lead to undesired behavior, especially given that is was used almost everywhere as a default. I think the decision about what to do when the start state is in collision should be made in a higher level logic than the planning pipeline.

We refactored the whole planning pipeline in moveit2 recently.

from moveit2.

github-actions avatar github-actions commented on September 12, 2024

This issue is being labeled as stale because it has been open 45 days with no activity. It will be automatically closed after another 45 days without follow-ups.

from moveit2.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.