GithubHelp home page GithubHelp logo

[Task]: Udpate docs about addons HOT 1 OPEN

KevinMind avatar KevinMind commented on September 27, 2024
[Task]: Udpate docs

from addons.

Comments (1)

KevinMind avatar KevinMind commented on September 27, 2024

IT should be very fast once you've run it once or twice. I just ran it in 39 seconds.
make update_docker does

snapshot of data
run make up
restore data from the snapshot in step 1.
Otherwise they are the same.

TheOne
now I am confused. Does up stand for update or for up as in the opposite of down?
Is there are way to start/run the containers without updating the images?
eviljeff
/agree that make up is hella ambigious
TheOne
I think we need to come up with better make target names.
Today
kmeinhardt@kmeinhardt:mozilla.org
make up is like docker compose up with dependencies.

If you checkout the project fresh, and run docker compose up.. it will fail.

make up, adds the necessary files (version.json, .env) based on the local environment and your specifications so that docker compose up will not fail.

Additionally (after this pr lands) after your run make up once, running docker compose commands should behave the same whether run via make or directly on the shell.

TheOne
if you look at what make up does, it runs a command called make docker_compose_up if you want to JUST run the containers, that will do it. it just runs a docker compose up command with the right arguments.

"Fix makefile env variables definition" by KevinMind ยท Pull Request #22246 ยท mozilla/addons-server - GitHub
Fixes: #14787 Description The makefile env variables were not defined correctly, causing issues with the configuration of the containers. This pull request fixes the definition of the...
TheOne
I think we need to come up with better make target names.
I very much agree.

make docker up reads better to me. Like we should reorganize the make targets based on the "domain"

make docker (up|update|down|shell|clean)

make test (js|python|assets|etc)

make build (image|assets|locales)

TheOne
now I am confused. Does up stand for update or for up as in the opposite of down?
second one. There is a command for updating the docker compose project. The intended idea of make up is it is a "one shot" command for making the entire project "up". Like you just run that one command and everything that needs to happen will happen. ideally this is the command you run 99% of the time to make sure your environment is "up"

from addons.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.