Comments (1)
IT should be very fast once you've run it once or twice. I just ran it in 39 seconds.
make update_docker does
snapshot of data
run make up
restore data from the snapshot in step 1.
Otherwise they are the same.
TheOne
now I am confused. Does up stand for update or for up as in the opposite of down?
Is there are way to start/run the containers without updating the images?
eviljeff
/agree that make up is hella ambigious
TheOne
I think we need to come up with better make target names.
Today
kmeinhardt@kmeinhardt:mozilla.org
make up is like docker compose up with dependencies.
If you checkout the project fresh, and run docker compose up.. it will fail.
make up, adds the necessary files (version.json, .env) based on the local environment and your specifications so that docker compose up will not fail.
Additionally (after this pr lands) after your run make up once, running docker compose commands should behave the same whether run via make or directly on the shell.
TheOne
if you look at what make up does, it runs a command called make docker_compose_up if you want to JUST run the containers, that will do it. it just runs a docker compose up command with the right arguments.
"Fix makefile env variables definition" by KevinMind ยท Pull Request #22246 ยท mozilla/addons-server - GitHub
Fixes: #14787 Description The makefile env variables were not defined correctly, causing issues with the configuration of the containers. This pull request fixes the definition of the...
TheOne
I think we need to come up with better make target names.
I very much agree.
make docker up reads better to me. Like we should reorganize the make targets based on the "domain"
make docker (up|update|down|shell|clean)
make test (js|python|assets|etc)
make build (image|assets|locales)
TheOne
now I am confused. Does up stand for update or for up as in the opposite of down?
second one. There is a command for updating the docker compose project. The intended idea of make up is it is a "one shot" command for making the entire project "up". Like you just run that one command and everything that needs to happen will happen. ideally this is the command you run 99% of the time to make sure your environment is "up"
from addons.
Related Issues (20)
- [Task]: Support new "enterprise" channel in add-on API
- [Task]: Skip source code submission for enterprise add-on versions
- [Task]: Auto-approve add-on versions in the enterprise channel
- [Task]: Provide a way for add-on operations to review and take action on enterprise add-on versions HOT 1
- [Task]: Ensure addons-server never assumes version channel is a binary choice
- [Task]: Functionality to search through canned responses on an add-on's review page
- [Bug]: Escape context log in actions
- [Task]: Fix intermittent test failures in TestUserAdmin.test_search_*
- [Task]: Update PR Template
- [Bug]: Help text when force enabling an add-on suggests that the comment will be sent to the developer HOT 11
- [Bug]: Escape links in <code> blocks HOT 1
- [Bug]: Unstable docker compose lifecycle
- [Bug]: Instability in docker compose lifecycle
- [Bug]: 500 returned on a particular content review page HOT 1
- remove release.yml workflow
- create a PR/branch for the modified deployment workflows HOT 1
- create events in event-router.yml that targets the above branch for running deployments
- Refine the deployment workflows until they are consistently working
- [Bug]: Extract Locales is not pushing
- [Task]: Add new `illegal_category` field in abuse reports HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from addons.