GithubHelp home page GithubHelp logo

Comments (2)

staktrace avatar staktrace commented on July 19, 2024

I was browsing around the mobile data a bit more today and a lot of the pushlog links and ranges given don't make much sense. For example, I was trying to figure out which change introduced the small bump in "Start" memory usage around Feb 8. After zooming in I see there is a gap in the data, with the last datapoint before the gap at 67.66 MB and the first datapoint after the gap at 68.45 MB. Clicking on the "before" shows one build with the cset 5e735fee82 and clicking on the "after" shows one build with the cset d60526b97a. So now what I want do do is get a pushlog of everything that changed between these two, but there's no link that I can see that does this. At the top of the "after" data box I see this:

68.45MiB Δ N.aNGiB
build 85751b3b03b6 .. d60526b97a17 (pushlog)

which has a number of problems: (1) is the NaN, (2) is that the build at the start of the range is not the last build for which we have data, (3) is that the pushlog link actually links to https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=3f864c99009d&tochange=d60526b97a17 which has a different start than what is displayed.

IMO the text should say "build 5e735fee82 .. d60526b97a17" and the pushlog should link to https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=5e735fee82&tochange=d60526b97a17

from areweslimyet.

Nephyrin avatar Nephyrin commented on July 19, 2024

The problem is the build range is showing all the builds that have any test data, rather than all the builds that have test data for that line.

As for pushlog links, they link from the last cset of the previous point to the last cset of the current point - the fromchange parameter is exclusive, rather than inclusive. So that part is correct - or would be if we properly excluded builds that have no test data.

I'm working on some patches that will fix this up

from areweslimyet.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.