GithubHelp home page GithubHelp logo

Comments (2)

msirringhaus avatar msirringhaus commented on September 26, 2024

AFAIK the reason auth-rs hasn't yet switched to serde_cbor_2 was basically that there was no need.
Indeed, cargo audit does complain, but Firefox uses cargo vet and their own vetting system, so they don't run into that problem.
serde_cbor_2 is basically a hard copy without any code changes to the original (and I know the people behind the fork). And rewiring this crate to the new dependency has significant overhead with regards to vendoring the new dependency in the Firefox repo.
So, as the sources are unchanged, the bump to serde_cbor_2 was not yet considered "worth the effort", I think.
auth-rs's usage of serde_cbor is pretty stable and has been vetted, so it being unmaintained shouldn't be a huge problem. And if a (security-) bug does arise, switching over to serde_cbor_2 is still an option.

from authenticator-rs.

mtnking avatar mtnking commented on September 26, 2024

I am aware of the nature of the fork - I'm the guy who opened the issue that prompted it and participated in the discussion around it. I'm not expecting immediate action, but I would hope it would not be so casually dismissed as "well it's not causing a problem for me, we'll wait for an exploit". If the inconvenience of changing is as significant as you suggest, an exploit is not the time to need to go through all that, given that it has impact on Firefox.

from authenticator-rs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.