dataset_metadata.yaml not correctly updated when deprecated: true about bigquery-etl

[whd]

I think in the PR this isn't an issue, but the intent should be for default_table_workgroup_access to get set to whatever workgroup_access was as opposed to workgroup:mozilla-confidential specifically. For instance, a deprecated table in https://github.com/mozilla/bigquery-etl/blob/main/sql/moz-fx-data-shared-prod/contextual_services/dataset_metadata.yaml should wind up with the generated dataset metadata looking like:

workgroup_access: []
default_table_workgroup_access:
- role: roles/bigquery.dataViewer
  members:
  - workgroup:contextual-services

[scholtzan]

Right, default_table_workgroup_access has been getting set correctly to whatever workgroup_access was. The missing piece was setting workgroup_access: [] for datasets with deprecated tables.