GithubHelp home page GithubHelp logo

Comments (10)

sedge avatar sedge commented on August 23, 2024

When our thimble is being loaded, there's a number of requests (~70!) that just flat out fail. These need to be addressed.

from brackets.

humphd avatar humphd commented on August 23, 2024

Hilariously, Thimble is loading jquery-ui (426K), jquery (262K), and other scripts in unminified form, which is adding a ton of heft. So that will help a lot. I'll fix upstream. We also load jquery.min.

Other things not minified for some reason, and being loaded by friendlycode and/or brackets:

  • require.js (we also load the minified version)
  • slowparse.js (we also load this twice in HTMLHinter and friendlycode)

Because the extensions are bundled into a single module and minified, we're also loading things many times (e.g., the requirejs text plugin gets loaded at least 6 times).

Also, the webmakerLogin.min.js is 225K, which is a bit hard to swallow. I'll see if I can get that shrunk down upstream too.

So there's some pretty quick wins here. I bet we'll find other things we can kill off, since we don't need to duplicate some functionality across the various iframes/repos.

from brackets.

humphd avatar humphd commented on August 23, 2024

Filed/fixed mozilla/thimble.mozilla.org#472 to fix minifying CDN resources in Thimble.

from brackets.

humphd avatar humphd commented on August 23, 2024

Filed mozilla/webmaker-login-ux#167 on webmakerLogin.min.js

from brackets.

humphd avatar humphd commented on August 23, 2024

The font loading Brackets is doing adds a lot of weight on the wire. Pomax filed a bug upstream on this, adobe#10680

from brackets.

humphd avatar humphd commented on August 23, 2024

Filed #78 on reducing the size of fonts we load, which gets us down to the sub-600K level.

from brackets.

humphd avatar humphd commented on August 23, 2024

Landed #74, which helps a bunch.

from brackets.

AJDBenner avatar AJDBenner commented on August 23, 2024

This PR will help reduce the size by about 100K before gzip

from brackets.

AJDBenner avatar AJDBenner commented on August 23, 2024

This PR helps reduce the size.

from brackets.

humphd avatar humphd commented on August 23, 2024

The only concrete thing left is the font switch, which is #78, so I'm going to close this bug. We made a huge dent, nice work!

from brackets.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.