Comments (8)
I'd suggest override: start #12345
in that case (with corresponding end
) where 12345
is an issue number. That way custom code can always be traced back to the "why" at the project level.
from network-api.
/cc @alanmoo @cadecairos @arush0311
from network-api.
This will require updating several files that we already made modifications to in the app/networkapi/static
as well as the app/networkapi/templates
directories
from network-api.
Additional, we should also have code comments following any override: start that explain the modification
@Pomax In my case the overridden content was several blocks of lines in different places, all collectively doing one thing. What about override: start <keyword>
and we explain those keywords at top of file? Also I think we should also comment out the removed content instead of deleting them
from network-api.
added to the readme
from network-api.
@gvn something for MoFo standards maybe?
from network-api.
Yeah that seems reasonable, although fairly domain specific if it's just regarding Mezzanine?
from network-api.
I guess the idea is mezzanine here, but for any framework that we use where we need to "monkey patch" (I know that's not what this is, technically, but taking a 2000 line file and updating 10 lines sure feels like it =D) it's good to know there's one particular style we use, modulo the actual comment syntax (<!-- ... -->
vs # ...
vs ''' ... '''
vs /* ... */
vs {# ... #}
vs etc. etc.)
from network-api.
Related Issues (20)
- cannot read env variables HOT 1
- Upload doesn't work in local dev
- Audit the code for queryset caching HOT 2
- Fix deployment breakage when DEBUG=False HOT 3
- Change default permissions for Mozillians HOT 6
- Implement Auth0 HOT 1
- Changing order of highlights doesn't work HOT 4
- Add logging for templating errors HOT 2
- Build "Upcoming" items model HOT 10
- Update backend to support identification of primary news item for homepage HOT 2
- Remove user-associated profiles when deleting a user HOT 1
- add an indicator to the user admin to show which account is django vs. social auth HOT 2
- see if we can rename the `is_staff` flag to `has_admin_access` to reflect what it does HOT 1
- problems getting admin access for new users HOT 2
- Cannot upload thumnails in local dev HOT 3
- refine the user groups HOT 2
- News article serializer dont have an id attribute HOT 1
- the admin site shows mezzanine in title HOT 1
- Milestones endpoint only shows some items HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from network-api.