GithubHelp home page GithubHelp logo

Comments (8)

Pomax avatar Pomax commented on July 29, 2024 2

I'd suggest override: start #12345 in that case (with corresponding end) where 12345 is an issue number. That way custom code can always be traced back to the "why" at the project level.

from network-api.

Pomax avatar Pomax commented on July 29, 2024

/cc @alanmoo @cadecairos @arush0311

from network-api.

Pomax avatar Pomax commented on July 29, 2024

This will require updating several files that we already made modifications to in the app/networkapi/static as well as the app/networkapi/templates directories

from network-api.

arush0311 avatar arush0311 commented on July 29, 2024

Additional, we should also have code comments following any override: start that explain the modification

@Pomax In my case the overridden content was several blocks of lines in different places, all collectively doing one thing. What about override: start <keyword> and we explain those keywords at top of file? Also I think we should also comment out the removed content instead of deleting them

from network-api.

Pomax avatar Pomax commented on July 29, 2024

added to the readme

from network-api.

alanmoo avatar alanmoo commented on July 29, 2024

@gvn something for MoFo standards maybe?

from network-api.

gvn avatar gvn commented on July 29, 2024

Yeah that seems reasonable, although fairly domain specific if it's just regarding Mezzanine?

from network-api.

Pomax avatar Pomax commented on July 29, 2024

I guess the idea is mezzanine here, but for any framework that we use where we need to "monkey patch" (I know that's not what this is, technically, but taking a 2000 line file and updating 10 lines sure feels like it =D) it's good to know there's one particular style we use, modulo the actual comment syntax (<!-- ... --> vs # ... vs ''' ... ''' vs /* ... */ vs {# ... #} vs etc. etc.)

from network-api.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.