GithubHelp home page GithubHelp logo

oghliner.deploy is a footgun about oghliner HOT 3 OPEN

mykmelez avatar mykmelez commented on July 19, 2024
oghliner.deploy is a footgun

from oghliner.

Comments (3)

delapuente avatar delapuente commented on July 19, 2024
  • make oghliner.offline generate a checksum or other artifact from the set of files being offlined, then make oghliner.deploy verify the checksum and fail if it doesn't match the one generated by oghliner.offline.

This is already the case so maybe we could use that as a lock (I'm thinking of adding a .version file with the digest) to stop the offline process to work unnecessary but my concern is if this work we are saving worth the effort as the only remaining step is to write to disk (though it could be reason enough).

from oghliner.

mykmelez avatar mykmelez commented on July 19, 2024

This is already the case so maybe we could use that as a lock (I'm thinking of adding a .version file with the digest) to stop the offline process to work unnecessary but my concern is if this work we are saving worth the effort as the only remaining step is to write to disk (though it could be reason enough).

It might not be worth the effort merely to avoid re-generating an up-to-date worker on offline. But it is surely worth the effort to avoid deploying an out-of-date worker on deploy!

from oghliner.

delapuente avatar delapuente commented on July 19, 2024

Sure, I realized that case later!

from oghliner.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.