Comments (13)
Updating Zeplin link by end of day here: https://app.zeplin.io/project/5db3524d3cd0612c5d2f78a9/dashboard?seid=5e1895eda13eea0232692323
- Main search typeahead: done
- search results page (landing page for when you use smaller search bar across site): done
- empty state / no results for both ^ : WIP
- tablet & mobile breakpoints for each : done
from sumo.
@kkellydesign all search designs updated in zeplin done
from sumo.
This is in! I piggybacked this work on the PR that is still pending here: mozilla/kitsune#4115
from sumo.
@kkellydesign minor updates here:
- 'search mozilla support' should just be search support.
- 'show everything' should be view all
- hint text / supportive text under the search bar that gives results -- the type style here feels off. I think we change it to inter regular weight or use metropolis at 24px like in the mockups.
On this same note / the mobile type scale is feeling a little unbalanced -- I need to relook at this system wide, should I check within the styleguide?
from sumo.
We did some testing around search functionality and we found several issues: #128
#129
#130
#131
#132
#133
#134
from sumo.
Typography adjustments are in ^^
These changes will be in when this PR is deployed: mozilla/kitsune#4150
from sumo.
This is ready for design review again, so I'm going to add the tag back to this. But @ovidiuboca1 raised some valid tickets/concerns about some UI issues with the frontend search. @madasan, Lets discuss this ticket in our next standup.
from sumo.
I want to do a follow up on this ticket, it was discussed (I don't remember)?
from sumo.
@ovidiuboca1 All of the design revisions from this ticket are in, so I think this one is safe to close. From our previous discussion, we decided that as long as these issues are also present in the production environment, we're going to table this work until the search upgrade project, where the instant-search is replaced by a more traditional search page. All of the tickets in the with the search upgrade
tag fall into that category.
from sumo.
@kkellydesign @ovidiuboca1 actually one last design tweak here with the type:
Right now the search items have a heading that is 20px and Metropolis -- should be Body LG 18px Inter Bold
from sumo.
This is finished and will go up in mozilla/kitsune#4193
from sumo.
@jess-cook03 do you think we can close this and move it to done?
from sumo.
@ovidiuboca1 yes confirmed this is fixed
from sumo.
Related Issues (20)
- Figure out a solution for archived products in the new taxonomy
- Check pageview counts in KB dashboard
- [L10n] Add periodic task scheduling for Celery
- Replace APScheduler and the cron K8s deployment with periodic Celery tasks
- Switching kb article from one non-default locale to another 404 HOT 1
- Navigating through the community forums is much more difficult for contributors with the recent spam increase
- Filter by product returns products with no articles and threads belonging to that topic category HOT 1
- Update topic description for the new taxonomy in the data migration HOT 1
- Rename "Topic" dropdown menu header to "Filter by Topic" inside the "Browse by product" and "Browse all forum threads by topic" pages
- Update wording in topic side menu. HOT 2
- [l10n] The "Cancel" button from the /users/edit page is not translated HOT 1
- [l10n] Several strings are missing localization from the Moderate Forum Content page HOT 1
- Unable to change the Question Details while on a non-US locale
- [l10n] Several strings are not localized inside the posted AAQ questions
- Update navigation menu to point to the new taxonomy HOT 1
- Update the browse by topic side menu to respect the new taxonomy
- Update the browse by product side menu to respect the new taxonomy
- Migrate AAQ topic options to the new taxonomy
- The "Reload Question Traffic Stats" weekly cron seems broken
- Both inbox heading and the message count notification are underlined inside the top-navbar HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sumo.