GithubHelp home page GithubHelp logo

Comments (13)

jess-cook03 avatar jess-cook03 commented on July 29, 2024

Updating Zeplin link by end of day here: https://app.zeplin.io/project/5db3524d3cd0612c5d2f78a9/dashboard?seid=5e1895eda13eea0232692323

  • Main search typeahead: done
  • search results page (landing page for when you use smaller search bar across site): done
  • empty state / no results for both ^ : WIP
  • tablet & mobile breakpoints for each : done

from sumo.

jess-cook03 avatar jess-cook03 commented on July 29, 2024

@kkellydesign all search designs updated in zeplin done

from sumo.

kkellydesign avatar kkellydesign commented on July 29, 2024

This is in! I piggybacked this work on the PR that is still pending here: mozilla/kitsune#4115

Screen Shot 2020-01-15 at 3 56 30 PM

Screen Shot 2020-01-15 at 3 56 44 PM

Screen Shot 2020-01-15 at 3 57 01 PM

from sumo.

jess-cook03 avatar jess-cook03 commented on July 29, 2024

@kkellydesign minor updates here:

  • 'search mozilla support' should just be search support.
  • 'show everything' should be view all
  • hint text / supportive text under the search bar that gives results -- the type style here feels off. I think we change it to inter regular weight or use metropolis at 24px like in the mockups.
    On this same note / the mobile type scale is feeling a little unbalanced -- I need to relook at this system wide, should I check within the styleguide?

from sumo.

ovidiuboca1 avatar ovidiuboca1 commented on July 29, 2024

We did some testing around search functionality and we found several issues: #128
#129
#130
#131
#132
#133
#134

from sumo.

kkellydesign avatar kkellydesign commented on July 29, 2024

Typography adjustments are in ^^

These changes will be in when this PR is deployed: mozilla/kitsune#4150

Screen Shot 2020-01-27 at 11 24 41 AM

Screen Shot 2020-01-27 at 11 24 50 AM

from sumo.

kkellydesign avatar kkellydesign commented on July 29, 2024

This is ready for design review again, so I'm going to add the tag back to this. But @ovidiuboca1 raised some valid tickets/concerns about some UI issues with the frontend search. @madasan, Lets discuss this ticket in our next standup.

from sumo.

ovidiuboca1 avatar ovidiuboca1 commented on July 29, 2024

I want to do a follow up on this ticket, it was discussed (I don't remember)?

from sumo.

kkellydesign avatar kkellydesign commented on July 29, 2024

@ovidiuboca1 All of the design revisions from this ticket are in, so I think this one is safe to close. From our previous discussion, we decided that as long as these issues are also present in the production environment, we're going to table this work until the search upgrade project, where the instant-search is replaced by a more traditional search page. All of the tickets in the with the search upgrade tag fall into that category.

from sumo.

jess-cook03 avatar jess-cook03 commented on July 29, 2024

@kkellydesign @ovidiuboca1 actually one last design tweak here with the type:
Screen Shot 2020-02-24 at 1 05 34 PM
Right now the search items have a heading that is 20px and Metropolis -- should be Body LG 18px Inter Bold

from sumo.

kkellydesign avatar kkellydesign commented on July 29, 2024

This is finished and will go up in mozilla/kitsune#4193

from sumo.

ovidiuboca1 avatar ovidiuboca1 commented on July 29, 2024

@jess-cook03 do you think we can close this and move it to done?

from sumo.

jess-cook03 avatar jess-cook03 commented on July 29, 2024

@ovidiuboca1 yes confirmed this is fixed

from sumo.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.