GithubHelp home page GithubHelp logo

Comments (8)

jess-cook03 avatar jess-cook03 commented on July 29, 2024

@kkellydesign designs are up in Zeplin
Let me know if you have questions. Ideally the search results will resemble this design as well. Im working through those pages still. Some UX thinking needs to happen.
But these are ready to go.

from sumo.

kkellydesign avatar kkellydesign commented on July 29, 2024

These changes will be ready for design review when this PR is deployed: mozilla/kitsune#4150

https://test.sumo.mozit.cloud/en-US/products/firefox

Screen Shot 2020-01-30 at 5 05 14 PM

from sumo.

kkellydesign avatar kkellydesign commented on July 29, 2024

This is in, and now all icons are working:
https://test.sumo.mozit.cloud/en-US/products/firefox

from sumo.

jess-cook03 avatar jess-cook03 commented on July 29, 2024

@kkellydesign @ovidiuboca1
Certain product pages like Firefox for example -- you click the topics and you get this error?
Screen Shot 2020-02-24 at 1 51 20 PM
Is this a data back end thing?
This page should be for example breadcrumb: Home / Firefox / Basic Browsing

from sumo.

jess-cook03 avatar jess-cook03 commented on July 29, 2024

Screen Shot 2020-02-24 at 2 01 16 PM
@kkellydesign

  • Volunteer button should be mozilla volunteer component

  • filters here -- these should reflect any sub topics that a selected topic may have from the mocks and heres an example from the current site:
    Screen Shot 2020-02-24 at 2 42 22 PM

from sumo.

kkellydesign avatar kkellydesign commented on July 29, 2024

Certain product pages like Firefox for example -- you click the topics and you get this error?

Yes, I ran that by Tasos a couple of weeks ago and it's some sort of timeout issue. I'm not getting it locally with a stripped-down database. He said it's safe to ignore

EDIT: these appear to be related issues, as I've figured out how to reproduce the staging error locally. @akatsoulas could you have a look at this?

  • Go here, and everything is fine: 127.0.0.1:8000/products/firefox/get-started
  • If you go to admin, there are no topics that have a parent: http://127.0.0.1:8000/admin/products/topic/
  • Add "Learn the Basics: get started" as the parent to "Topics" and "Bookmarks" like this:

Screen Shot 2020-02-25 at 7 53 55 PM

  • Then go back to the get started page, and get "'topic' is undefined"

I have compared my code to master, and I can't find where the problem might be. Here's the full trace of the error. I assume this is the same as you'll find in the logs for https://test.sumo.mozit.cloud/en-US/products/firefox/basic-browsing-firefox.

from sumo.

kkellydesign avatar kkellydesign commented on July 29, 2024

This is fixed, and will go up with mozilla/kitsune#4193

Screen Shot 2020-02-26 at 11 40 48 AM

from sumo.

jess-cook03 avatar jess-cook03 commented on July 29, 2024

Confirming this is all resolved

from sumo.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.