GithubHelp home page GithubHelp logo

Comments (7)

kkellydesign avatar kkellydesign commented on July 29, 2024 1

I believe this is either an issue with data differences, or subproducts not being implemented yet in the responsive-redesign branch. @akatsoulas, can you confirm?

from sumo.

jess-cook03 avatar jess-cook03 commented on July 29, 2024

@kkellydesign @madasan @akatsoulas @flekkowich
Subproduct pages link to designs in Zeplin
To be reviewed in today's designs review meeting.

from sumo.

kkellydesign avatar kkellydesign commented on July 29, 2024

@madasan This is in: mozilla/kitsune#4085
Here's a local link: http://127.0.0.1:8000/en-US/products/firefox

I have one question on this one. In non-firefox browsers, we have this:

Screen Shot 2019-12-13 at 8 53 32 AM

On the current site, this is what it looks like:
Screen Shot 2019-12-13 at 8 55 57 AM

Do we still need that? If so, should I just use the blue filled-in button and recreate the layout from the old site?

from sumo.

madasan avatar madasan commented on July 29, 2024

Yes, we need to keep the download button

from sumo.

kkellydesign avatar kkellydesign commented on July 29, 2024

This is in:
Screen Shot 2019-12-20 at 7 29 32 AM

from sumo.

kkellydesign avatar kkellydesign commented on July 29, 2024

https://test.sumo.mozit.cloud/en-US/products/firefox

This is ready for QA, with some exceptions. Static files are still not loading, which means:

  • Fonts are using the sans-serif fallback instead of Inter and Metropolis.
  • The masthead photo is displaying the alt tag for the broken image instead of the logo. Here's what that looks like for me locally, where the fallback image is working correctly. To be clear, that's what happens when there's an empty field in the database, not a broken link. When the staticfiles works, it should populate the actual firefox logo in this spot.

Screen Shot 2020-01-24 at 3 02 07 PM

* Icons under 'frequent topics' and 'featured articles' are both missing. * The close button on notifications is missing.

Additional notes:
In an upcoming PR, the search on this page will work identically to the homepage. It's functional now, but the layout is a bit off. The icons on search results are also related to the staticfiles issue.

from sumo.

ovidiuboca1 avatar ovidiuboca1 commented on July 29, 2024

Comparing the dev environment and the staging one related to the sub-products pages I see different behavior. On https://test.sumo.mozit.cloud/en-US/ I don't see any sub-product pages. I did a screen recording where I compared the dev environment, where the sub-product pages exist and the test environment where I don't see any sub-product pages: https://streamable.com/nhoqt

from sumo.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.