Comments (6)
Alas, seems this was introduced by https://github.com/mozilla/webmaker-core/pull/924/files. If we can't find an easy fix, let's remove this and ignore my request to retain trailing and leading spaces by users.
They way we handle text wrap of a scalable element has always been a bit odd (linking fontsize bounding box), but now's not the time to reinvent how we handle text elements.
from webmaker-core.
Since @alanmoo is out, let's remove this patch for now and confirm that it fixes the bug.
from webmaker-core.
@alanmoo now that you're back, wanna take a look see?
from webmaker-core.
Sure thing!
from webmaker-core.
I believe I can fix this by removing the max-width of elements in the editor CSS. However that only fixes the visual bug, there's still a question of expected UI behavior and text wrapping. Currently (and with this possible fix), elements simply won't wrap, and there's no way to add a manual line break because the Android keyboard doesn't offer it (presumably because it's an input
element). Is this ok? I'm inclined to believe it is, as enabling line breaks encourages longer pieces of text, but I'm also not sure what users want here. Thoughts, @xmatthewx?
from webmaker-core.
I wasn't a part of the discussion when this was originally implemented. I know there was a bit of debate on how to handle this.
At this stage, we have to maintain the rendering of existing text elements, which have a forced line-wrap based on initial font-size and scale. If we try and remove one errant stitch, we'll likely unravel our sweater.
We don't have time to implement what I think is the ideal solution... two text elements: Headers (font scales with element, no-wrap, like Alan describes), Paragraphs (bounding box resizes and text reflows, font-size set with UI slider). Maybe in a future release.
For now, let's just look at that patch and see how much of it we need to roll back to fix this.
Make sense?
from webmaker-core.
Related Issues (20)
- Discover doesn't update, can't refresh HOT 9
- Update ESLint configuration to prevent future failures of Travis CI builds
- Remove Beta from project share URLs
- Add ability to swipe between project pages HOT 4
- Ryan's todo list
- Quick Discover Fix HOT 5
- Webmaker App for Android no longer available HOT 4
- [email protected] no longer in use
- Release 1.6.2 HOT 14
- Update logo on Webmaker Firefox OS app HOT 1
- Quick design review HOT 4
- Trailing space in description doesn't get removed
- Extend API pagination
- Show elements in editor on the background color of the page
- Gray block being the keyboard in login screen HOT 7
- Revise tag view header HOT 2
- Thumbnails are missing page background color HOT 3
- Thumbnail service is failing HOT 1
- Project titles don't persist without a description HOT 8
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from webmaker-core.