Building fails in Fedora 32 about tty-solitaire

[mpereira]

@dther thanks for the report. Are you able to investigate? Unfortunately I don't currently have access to a Fedora or Arch environment.

[mpereira]

Hi @Baggypants,

Thanks for the report. I'd be curious to know the version of gcc in Fedora 32 and the Python scripts building tty-solitaire. It looks like it's trying to somehow link duplicate object files? For example, for the "cursor" object, if we look at this line output:

src/cursor.o:/builddir/build/BUILD/tty-solitaire-1.1.1/src/game.h:38: multiple definition of `cursor'; /tmp/ccVwI7VH.o:/builddir/build/BUILD/tty-solitaire-1.1.1/src/game.h:38: first defined here

There are both
src/cursor.o:/builddir/build/BUILD/tty-solitaire-1.1.1/src/game.h:38
and
/tmp/ccVwI7VH.o:/builddir/build/BUILD/tty-solitaire-1.1.1/src/game.h:38

And game.h:38 is:

struct cursor *cursor;

Do you have a Fedora setup and would be able to debug it?

[Baggypants]

[baggypants@buildserver ~]$ rpm -qa gcc
gcc-10.0.1-0.13.fc32.x86_64

The python stuff is just the automated build system and doesn't impact on the build. Heres the HEAD build on a classic make-in-a-directory machine

[baggypants@buildserver tty-solitaire]$ make
cc -g -W -Wall -pedantic -ansi -std=c99 -DVERSION=\"1.1.1\" src/ttysolitaire.c -o ttysolitaire src/common.o src/frame.o src/card.o src/stack.o src/deck.o src/cursor.o src/keyboard.o src/gui.o src/game.o  -lncursesw
/usr/bin/ld: src/cursor.o:(.bss+0x0): multiple definition of `deck'; /tmp/cce1xEvH.o:(.bss+0x0): first defined here
/usr/bin/ld: src/cursor.o:/home/baggypants/Develop/tty-solitaire/src/game.h:38: multiple definition of `cursor'; /tmp/cce1xEvH.o:/home/baggypants/Develop/tty-solitaire/src/game.h:38: first defined here
/usr/bin/ld: src/keyboard.o:(.bss+0x0): multiple definition of `deck'; /tmp/cce1xEvH.o:(.bss+0x0): first defined here
/usr/bin/ld: src/keyboard.o:(.bss+0x8): multiple definition of `cursor'; /tmp/cce1xEvH.o:/home/baggypants/Develop/tty-solitaire/src/game.h:38: first defined here
/usr/bin/ld: src/gui.o:(.bss+0x0): multiple definition of `deck'; /tmp/cce1xEvH.o:(.bss+0x0): first defined here
/usr/bin/ld: src/gui.o:/home/baggypants/Develop/tty-solitaire/src/game.h:38: multiple definition of `cursor'; /tmp/cce1xEvH.o:/home/baggypants/Develop/tty-solitaire/src/game.h:38: first defined here
/usr/bin/ld: src/game.o:(.bss+0x0): multiple definition of `deck'; /tmp/cce1xEvH.o:(.bss+0x0): first defined here
/usr/bin/ld: src/game.o:/home/baggypants/Develop/tty-solitaire/src/game.h:38: multiple definition of `cursor'; /tmp/cce1xEvH.o:/home/baggypants/Develop/tty-solitaire/src/game.h:38: first defined here
collect2: error: ld returned 1 exit status
make: *** [Makefile:48: ttysolitaire] Error 1
[baggypants@buildserver tty-solitaire]$

[dther]

Similar error on Arch. Downgrading gcc and gcc-libs to 9.3.0-1 produces no errors. Current version is 10.1.0-2.

$ make
cc -g -W -Wall -pedantic -ansi -std=c99 -DVERSION=\"1.1.1\" src/ttysolitaire.c -o ttysolitaire src/common.o src/frame.o src/card.o src/stack.o src/deck.o src/cursor.o src/keyboard.o src/gui.o src/game.o  -lncursesw
/usr/bin/ld: src/cursor.o:(.bss+0x0): multiple definition of `deck'; /tmp/cchdIJta.o:(.bss+0x0): first defined here
/usr/bin/ld: src/cursor.o:/home/dther/repos/tty-solitaire/src/game.h:38: multiple definition of `cursor'; /tmp/cchdIJta.o:/home/dther/repos/tty-solitaire/src/game.h:38: first defined here
/usr/bin/ld: src/keyboard.o:(.bss+0x0): multiple definition of `deck'; /tmp/cchdIJta.o:(.bss+0x0): first defined here
/usr/bin/ld: src/keyboard.o:(.bss+0x8): multiple definition of `cursor'; /tmp/cchdIJta.o:/home/dther/repos/tty-solitaire/src/game.h:38: first defined here
/usr/bin/ld: src/gui.o:(.bss+0x0): multiple definition of `deck'; /tmp/cchdIJta.o:(.bss+0x0): first defined here
/usr/bin/ld: src/gui.o:/home/dther/repos/tty-solitaire/src/game.h:38: multiple definition of `cursor'; /tmp/cchdIJta.o:/home/dther/repos/tty-solitaire/src/game.h:38: first defined here
/usr/bin/ld: src/game.o:(.bss+0x0): multiple definition of `deck'; /tmp/cchdIJta.o:(.bss+0x0): first defined here
/usr/bin/ld: src/game.o:/home/dther/repos/tty-solitaire/src/game.h:38: multiple definition of `cursor'; /tmp/cchdIJta.o:/home/dther/repos/tty-solitaire/src/game.h:38: first defined here
collect2: error: ld returned 1 exit status
make: *** [Makefile:48: ttysolitaire] Error 1

[mpereira]

@Baggypants v1.3.0 was released with a fix for this. Thanks again for reporting!