Add "--enable-pic/--with-pic" in libass/ffmpeg/fribidi configure scripts for build libmpv about mpv-build

I don't think it makes sense to build libmpv with mpv-build, at least not yet...

[kevmitch]

wm4: because its not yet considered stable enough?

And because mpv-build is still intended to build the command line player.

As long as there's nothing actually using libmpv, there's no use building it either. It's only interesting for those who want to try the API, and those are developers and can build it manually anyway.

I'm not sure if always compiling everything with -fPIC has any downsides (maybe not, though it might make code slightly slower), but for now I'd rather not touch it.

We'll see where this goes...

[dr-vsn]

The company I work for is evaluating mpv as a mplayer2 replacement. One of the larger appeals is using libmpv instead of interfacing with mplayer2 via the command line and hooking that up to Qt, we could potentially just use libmpv. Most people here use Ubuntu for their dev boxes, so this does pose an issue for development with libmpv. I ran into the same issue mentioned here just earlier today. We do use Gentoo for our production machines but this should not need to be an issue.

[dr-vsn]

@sl1pkn07: Would you be willing to post a diff of your changes to the configure scripts to get this to build a shared library properly?

I guess now that the mpv release includes libmpv, we could probably think about this.

One problem is that I'm not sure whether -fPIC causes (even if minor) performance reduction. Or in other words, whether it's always safe to add -fPIC. Considering libass and ffmpeg are usually built as shared libs, this is probably no problem at all, though.

[dr-vsn]

One problem is that I'm not sure whether -fPIC causes (even if minor) performance reduction. Or in other words, whether it's always safe to add -fPIC. Considering libass and ffmpeg are usually built as shared libs, this is probably no problem at all, though.

Perhaps you could just make it an option that can be set for the build in total, and have it echo a warning saying the performance characteristics are unknown. Just a thought.

OK it should work now. PIC is enabled if building libmpv is enabled.

I also added instructions how to enable libmpv to the README.

[dr-vsn]

Thanks for the help! Good work by the way!

[sl1pkn07]

too late, but

http://pkgbuild.com/git/aur-mirror.git/plain/mpv-build-git/fribidi_configure_like_ffmpeg_configure.patch
http://pkgbuild.com/git/aur-mirror.git/tree/mpv-build-git/libass_configure_like_ffmpeg_configure.patch

then
echo "--with-pic" > libass_options
echo "--with-pic" > fribidi_options
echo"--some-foo --enable-pic" > ffmpeg_options

greetings