GithubHelp home page GithubHelp logo

Comments (3)

pjvandehaar avatar pjvandehaar commented on June 20, 2024

Oh, window.scrollTo doesn't work on a frameset. Better option:

if(document.querySelectorAll('frameset').length>0) {
  alert('Sorry, this page is a frameset, which is not supported');
}

from full-page-screen-capture-chrome-extension.

mrcoles avatar mrcoles commented on June 20, 2024

Iā€™m leaving out frameset support for now. You can checkout some workarounds in #58

from full-page-screen-capture-chrome-extension.

pjvandehaar avatar pjvandehaar commented on June 20, 2024

That seems like a good choice. I still think it'd be good to let users know what's going on when the extension fails on a frameset (as per #22 (comment)), but you're free to do whatever you like.

from full-page-screen-capture-chrome-extension.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    šŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. šŸ“ŠšŸ“ˆšŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ā¤ļø Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.