Joint wavelet regularization not supported in pics about bart

[uecker]

See my attemp for wavelet3 in joint-wavelet2 ... completely untested but I think it should work...

[jtamir]

Is your wavelet3 competitive in speed with wavelet2 on CPU and GPU?

If not I still prefer to have the special case of wavelet2 + unitary
threshold for 3D, since I use it in a clinical setting. If it is then we
should get rid of wavelet2 completely.

Jon

On Wed, Aug 10, 2016 at 6:24 AM, Martin Uecker [email protected]
wrote:

See my attemp for wavelet3 in joint-wavelet2 ... completely untested but I
think it should work...

—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
#54 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AIUBa7nHyPgcB7h4Rr_cBCc31zFcZz3Kks5qedEDgaJpZM4JKs-u
.

[uecker]

No, for the CPU it depends on circumstances and the GPU case is slow. Otherwise I would have removed the wavelet2 code a long time ago...

[uecker]

Actually, I did some tests and it seems fast even on the GPU. Maybe because newer ones have a cache and do not rely as much on the explicit use of the shared memory. Are you OK with removing wavelet2?

[jtamir]

I will check when I have a chance. @frankong thoughts?

[frankong]

I'm ok if it's faster. Wavelet2 has served its time

On Aug 12, 2016, at 5:35 AM, Jon Tamir [email protected] wrote:

I will check when I have a chance. @frank thoughts?

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

[jtamir]

What's the latest on this? I rebased the wavelet branch. Do we have any performance regression tests?

[uecker]

Not sure what branch you are talking about...

the old wavelets are not used by default anymore. My plan is to make another release soon, and if nobody complaints too loudly, remove wavelet2 in the release after this.

For joint thresholding, somebody needs to test whether joint wavelet thresholding in the joint-wavelets2 branch works as intended and contribute a test. Then we could merge that feature.

[jtamir]

Okay, I will take a look. That's the branch I'm talking about

[uecker]

Implemented on master. Still needs testing