GithubHelp home page GithubHelp logo

Comments (2)

mrkkrp avatar mrkkrp commented on May 31, 2024

We could use solution proposed by @neongreen, but before we do, I think we should create test suite to clearly state properties of notFollowedBy in MegaParsec. Also, it's necessary to check performance of the solution, criterion can be used here to compare speed of original implementation and the proposed one.


Postponed until necessary testing and benchmarking are implemented.

from megaparsec.

mrkkrp avatar mrkkrp commented on May 31, 2024

This is fixed now. I've decided to write the combinator on lower level, in Text.Megaparsec.Prim, this way it doesn't get hairy:

-- | @notFollowedBy p@ only succeeds when parser @p@ fails. This parser
-- does not consume any input and can be used to implement the “longest
-- match” rule.

notFollowedBy :: Stream s m t => ParsecT s u m a -> ParsecT s u m ()
notFollowedBy p = ParsecT $ \s@(State input pos _) _ _ eok eerr -> do
  l <- maybe eoi (showToken . fst) <$> uncons input
  let cok' _ _ _ = eerr $ unexpectedErr l pos
      cerr'    _ = eok () s mempty
      eok' _ _ _ = eerr $ unexpectedErr l pos
      eerr'    _ = eok () s mempty
  unParser p s cok' cerr' eok' eerr'

Since I'm doing major reorganization of the module and the solution depends on new concept of hints, the change will be committed among other changes soon (not as a separate commit).

λ> parseTest (lookAhead (string "a")) "abc"
"a"
λ> parseTest (notFollowedBy (lookAhead (string "a"))) "abc"
parse error at line 1, column 1:
unexpected 'a'
λ> parseTest (many (char 'r') *> notFollowedBy (lookAhead (string "a"))) "ra"
parse error at line 1, column 2:
unexpected 'a'
expecting 'r'
λ> parseTest (many (char 'r') <* notFollowedBy (lookAhead (string "b"))) "ra"
"r"
λ> parseTest (notFollowedBy $ notFollowedBy (string "a")) "abc"
()
λ> parseTest (many (char 'r') <* notFollowedBy eof) "ra"
"r"
λ> parseTest (many (char 'r') <* notFollowedBy eof) "r"
parse error at line 1, column 2:
unexpected end of input
expecting 'r'

from megaparsec.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.