MySQL provider - keep connection about invsync

[Bizzonium]

[MrNavaStar]

Huh, that's weird. It should set the up table itself. Keeping the connection open won't work because it will lock up for any other transaction. Does it work fine despite these errors?

[Bizzonium]

No, server hangs

[MrNavaStar]

Oh, that's not good! Does this happen every time you switch servers or just occasionally?

[Bizzonium]

Oh, that's not good! Does this happen every time you switch servers or just occasionally?

Just occasionally. Also i suggest to implement some features from HuskSync https://www.spigotmc.org/resources/husksync-1-16-1-17-1-18-synchronize-player-inventories-data-cross-server.97144/ . That would be sweet but i understand it would be much harder and time-costly

[MrNavaStar]

Sorry the link doesn't work for me. Could you please request specific things? Maybe make a new issue for them also.

Im not really sure what to do about the issue here tho. The error doesn't really have much useful. You said you manually created all the columns in the table? Why?

[Bizzonium]

Sorry the link doesn't work for me. Could you please request specific things? Maybe make a new issue for them also.

https://github.com/WiIIiam278/HuskSync yeap, definitly out of scope of this issue

Im not really sure what to do about the issue here tho. The error doesn't really have much useful. You said you manually created all the columns in the table? Why?

I don't remember exactly why. Maybe i encountered issue and thought it's the safest and quickest way. Maybe i should close this issue until i get more info about what's going on.

[MrNavaStar]

You can leave it open, but yeah I don't really have a lot to go on with this. Maybe you could try setting up a test server and see if you can reproduce the issue? Again the database should set it self up, so if that's not working there might be other things that need to be fixed.

[Bizzonium]

Again the database should set it self up

Checked it again, no issues. It works.

[MrNavaStar]

So is this issue no longer a problem?

[Bizzonium]

[17:00:39] [Netty Epoll Server IO #20/INFO]: [STDERR]: java.sql.SQLException: No operations allowed after statement closed.
[17:00:39] [Netty Epoll Server IO #20/INFO]: [STDERR]:  at com.mysql.cj.jdbc.exceptions.SQLError.createSQLException(SQLError.java:129)
[17:00:39] [Netty Epoll Server IO #20/INFO]: [STDERR]:  at com.mysql.cj.jdbc.exceptions.SQLError.createSQLException(SQLError.java:97)
[17:00:39] [Netty Epoll Server IO #20/INFO]: [STDERR]:  at com.mysql.cj.jdbc.exceptions.SQLError.createSQLException(SQLError.java:89)
[17:00:39] [Netty Epoll Server IO #20/INFO]: [STDERR]:  at com.mysql.cj.jdbc.exceptions.SQLError.createSQLException(SQLError.java:63)
[17:00:39] [Netty Epoll Server IO #20/INFO]: [STDERR]:  at com.mysql.cj.jdbc.exceptions.SQLError.createSQLException(SQLError.java:73)
[17:00:39] [Netty Epoll Server IO #20/INFO]: [STDERR]:  at com.mysql.cj.jdbc.exceptions.SQLExceptionsMapping.translateException(SQLExceptionsMapping.java:82)
[17:00:39] [Netty Epoll Server IO #20/INFO]: [STDERR]:  at com.mysql.cj.jdbc.StatementImpl.setQueryTimeout(StatementImpl.java:1896)
[17:00:39] [Netty Epoll Server IO #20/INFO]: [STDERR]:  at mrnavastar.sqlib.util.SqlManager.endTransaction(SqlManager.java:62)
[17:00:39] [Netty Epoll Server IO #20/INFO]: [STDERR]:  at mrnavastar.sqlib.api.databases.Database.endTransaction(Database.java:28)
[17:00:39] [Netty Epoll Server IO #20/INFO]: [STDERR]:  at mrnavastar.sqlib.api.Table.endTransaction(Table.java:55)
[17:00:39] [Netty Epoll Server IO #20/INFO]: [STDERR]:  at mrnavastar.invsync.InvSync.lambda$onInitialize$1(InvSync.java:58)
[17:00:39] [Netty Epoll Server IO #20/INFO]: [STDERR]:  at net.fabricmc.fabric.api.networking.v1.ServerPlayConnectionEvents.lambda$static$4(ServerPlayConnectionEvents.java:59)
[17:00:39] [Netty Epoll Server IO #20/INFO]: [STDERR]:  at net.fabricmc.fabric.impl.networking.server.ServerPlayNetworkAddon.invokeDisconnectEvent(ServerPlayNetworkAddon.java:140)
[17:00:39] [Netty Epoll Server IO #20/INFO]: [STDERR]:  at net.fabricmc.fabric.impl.networking.AbstractNetworkAddon.handleDisconnect(AbstractNetworkAddon.java:131)
[17:00:39] [Netty Epoll Server IO #20/INFO]: [STDERR]:  at net.minecraft.class_2535.handler$ejj000$handleDisconnect(class_2535.java:1590)
[17:00:39] [Netty Epoll Server IO #20/INFO]: [STDERR]:  at net.minecraft.class_2535.channelInactive(class_2535.java)
[17:00:39] [Netty Epoll Server IO #20/INFO]: [STDERR]:  at io.netty.channel.AbstractChannelHandlerContext.invokeChannelInactive(AbstractChannelHandlerContext.java:262)
[17:00:39] [Netty Epoll Server IO #20/INFO]: [STDERR]:  at io.netty.channel.AbstractChannelHandlerContext.invokeChannelInactive(AbstractChannelHandlerContext.java:248)
[17:00:39] [Netty Epoll Server IO #20/INFO]: [STDERR]:  at io.netty.channel.AbstractChannelHandlerContext.fireChannelInactive(AbstractChannelHandlerContext.java:241)
[17:00:39] [Netty Epoll Server IO #20/INFO]: [STDERR]:  at io.netty.handler.codec.ByteToMessageDecoder.channelInputClosed(ByteToMessageDecoder.java:389)
[17:00:39] [Netty Epoll Server IO #20/INFO]: [STDERR]:  at io.netty.handler.codec.ByteToMessageDecoder.channelInactive(ByteToMessageDecoder.java:354)
[17:00:39] [Netty Epoll Server IO #20/INFO]: [STDERR]:  at io.netty.channel.AbstractChannelHandlerContext.invokeChannelInactive(AbstractChannelHandlerContext.java:262)
[17:00:39] [Netty Epoll Server IO #20/INFO]: [STDERR]:  at io.netty.channel.AbstractChannelHandlerContext.invokeChannelInactive(AbstractChannelHandlerContext.java:248)
[17:00:39] [Netty Epoll Server IO #20/INFO]: [STDERR]:  at io.netty.channel.AbstractChannelHandlerContext.fireChannelInactive(AbstractChannelHandlerContext.java:241)
[17:00:39] [Netty Epoll Server IO #20/INFO]: [STDERR]:  at io.netty.handler.codec.ByteToMessageDecoder.channelInputClosed(ByteToMessageDecoder.java:389)
[17:00:39] [Netty Epoll Server IO #20/INFO]: [STDERR]:  at io.netty.handler.codec.ByteToMessageDecoder.channelInactive(ByteToMessageDecoder.java:354)
[17:00:39] [Netty Epoll Server IO #20/INFO]: [STDERR]:  at io.netty.channel.AbstractChannelHandlerContext.invokeChannelInactive(AbstractChannelHandlerContext.java:262)
[17:00:39] [Netty Epoll Server IO #20/INFO]: [STDERR]:  at io.netty.channel.AbstractChannelHandlerContext.invokeChannelInactive(AbstractChannelHandlerContext.java:248)
[17:00:39] [Netty Epoll Server IO #20/INFO]: [STDERR]:  at io.netty.channel.AbstractChannelHandlerContext.fireChannelInactive(AbstractChannelHandlerContext.java:241)
[17:00:39] [Netty Epoll Server IO #20/INFO]: [STDERR]:  at io.netty.handler.codec.ByteToMessageDecoder.channelInputClosed(ByteToMessageDecoder.java:389)
[17:00:39] [Netty Epoll Server IO #20/INFO]: [STDERR]:  at io.netty.handler.codec.ByteToMessageDecoder.channelInactive(ByteToMessageDecoder.java:354)
[17:00:39] [Netty Epoll Server IO #20/INFO]: [STDERR]:  at io.netty.channel.AbstractChannelHandlerContext.invokeChannelInactive(AbstractChannelHandlerContext.java:262)
[17:00:39] [Netty Epoll Server IO #20/INFO]: [STDERR]:  at io.netty.channel.AbstractChannelHandlerContext.invokeChannelInactive(AbstractChannelHandlerContext.java:248)
[17:00:39] [Netty Epoll Server IO #20/INFO]: [STDERR]:  at io.netty.channel.AbstractChannelHandlerContext.fireChannelInactive(AbstractChannelHandlerContext.java:241)
[17:00:39] [Netty Epoll Server IO #20/INFO]: [STDERR]:  at io.netty.channel.ChannelInboundHandlerAdapter.channelInactive(ChannelInboundHandlerAdapter.java:81)
[17:00:39] [Netty Epoll Server IO #20/INFO]: [STDERR]:  at io.netty.handler.timeout.IdleStateHandler.channelInactive(IdleStateHandler.java:277)
[17:00:39] [Netty Epoll Server IO #20/INFO]: [STDERR]:  at io.netty.channel.AbstractChannelHandlerContext.invokeChannelInactive(AbstractChannelHandlerContext.java:262)
[17:00:39] [Netty Epoll Server IO #20/INFO]: [STDERR]:  at io.netty.channel.AbstractChannelHandlerContext.invokeChannelInactive(AbstractChannelHandlerContext.java:248)
[17:00:39] [Netty Epoll Server IO #20/INFO]: [STDERR]:  at io.netty.channel.AbstractChannelHandlerContext.fireChannelInactive(AbstractChannelHandlerContext.java:241)
[17:00:39] [Netty Epoll Server IO #20/INFO]: [STDERR]:  at io.netty.channel.DefaultChannelPipeline$HeadContext.channelInactive(DefaultChannelPipeline.java:1405)
[17:00:39] [Netty Epoll Server IO #20/INFO]: [STDERR]:  at io.netty.channel.AbstractChannelHandlerContext.invokeChannelInactive(AbstractChannelHandlerContext.java:262)
[17:00:39] [Netty Epoll Server IO #20/INFO]: [STDERR]:  at io.netty.channel.AbstractChannelHandlerContext.invokeChannelInactive(AbstractChannelHandlerContext.java:248)
[17:00:39] [Netty Epoll Server IO #20/INFO]: [STDERR]:  at io.netty.channel.DefaultChannelPipeline.fireChannelInactive(DefaultChannelPipeline.java:901)
[17:00:39] [Netty Epoll Server IO #20/INFO]: [STDERR]:  at io.netty.channel.AbstractChannel$AbstractUnsafe$8.run(AbstractChannel.java:831)
[17:00:39] [Netty Epoll Server IO #20/INFO]: [STDERR]:  at io.netty.util.concurrent.AbstractEventExecutor.safeExecute(AbstractEventExecutor.java:164)
[17:00:39] [Netty Epoll Server IO #20/INFO]: [STDERR]:  at io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:469)
[17:00:39] [Netty Epoll Server IO #20/INFO]: [STDERR]:  at io.netty.channel.epoll.EpollEventLoop.run(EpollEventLoop.java:384)
[17:00:39] [Netty Epoll Server IO #20/INFO]: [STDERR]:  at io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:986)
[17:00:39] [Netty Epoll Server IO #20/INFO]: [STDERR]:  at io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74)
[17:00:39] [Netty Epoll Server IO #20/INFO]: [STDERR]:  at java.base/java.lang.Thread.run(Unknown Source)
[17:00:39] [Netty Epoll Server IO #20/INFO]: [STDERR]: Caused by: com.mysql.cj.exceptions.StatementIsClosedException: No operations allowed after statement closed.
[17:00:39] [Netty Epoll Server IO #20/INFO]: [STDERR]:  at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
[17:00:39] [Netty Epoll Server IO #20/INFO]: [STDERR]:  at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(Unknown Source)
[17:00:39] [Netty Epoll Server IO #20/INFO]: [STDERR]:  at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(Unknown Source)
[17:00:39] [Netty Epoll Server IO #20/INFO]: [STDERR]:  at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Unknown Source)
[17:00:39] [Netty Epoll Server IO #20/INFO]: [STDERR]:  at java.base/java.lang.reflect.Constructor.newInstance(Unknown Source)
[17:00:39] [Netty Epoll Server IO #20/INFO]: [STDERR]:  at com.mysql.cj.exceptions.ExceptionFactory.createException(ExceptionFactory.java:61)
[17:00:39] [Netty Epoll Server IO #20/INFO]: [STDERR]:  at com.mysql.cj.exceptions.ExceptionFactory.createException(ExceptionFactory.java:85)
[17:00:39] [Netty Epoll Server IO #20/INFO]: [STDERR]:  at com.mysql.cj.jdbc.StatementImpl.checkClosed(StatementImpl.java:336)
[17:00:39] [Netty Epoll Server IO #20/INFO]: [STDERR]:  at com.mysql.cj.jdbc.StatementImpl.setQueryTimeout(StatementImpl.java:1889)
[17:00:39] [Netty Epoll Server IO #20/INFO]: [STDERR]:  ... 43 more

[MrNavaStar]

Okay so this is still an issue

[michiruf]

This happens for me reproducable, if I have 2 servers up and running, and then afterwards installing the InvSync mod. It does not happen on newly created server instances when the mod is already installed.

Tested on 1.19.2 and with both SQLITE and MySQL

[MrNavaStar]

Ah interesting. I'm not sure adding support for pre-existing servers is really a viable option however. How is the system supposed to know which server to sync items from? On a clean install it doesn't matter, cause both servers are blank. But on used ones one server needs to be over written. I'm guessing this has something to do with the issue, but I'm not sure how to go about resolving it.

Non the less Thank you for the reproduction steps, I will give them a try and see what I can come up with.

[michiruf]

If you push your latest changes, I can have a look too and figure out what might be causing this issue, if you want to

[MrNavaStar]

Same issue as #54

[MrNavaStar]

Fixed in new release