Comments (5)
The observer should additionally observe
/{node}/mode_event
topics to observe mode changes, e.g., a node going from normal mode to degraded mode. Messages sent on this topic are of type ModeEvent and very close to the TransitionEvent messages.
This should not be too complicated, but I have a couple questions:
- Should we read the
/{node}/mode_event
for the same nodes/systems as the/{node}/transition_event
or should we have a separated list on thecomponents.yaml
file? - What transitions should we look for when sending a diagnostics error? (i.e. For the
/{node}/transition_event
we're only checking thelifecycle_msgs::msg::State::TRANSITION_STATE_ERRORPROCESSING
tolifecycle_msgs::msg::State::PRIMARY_STATE_UNCONFIGURED
)
from mros_modes_observer.
I think de answer depends on how we decide to use metacontrol and system modes:
-
If it is a design decision to have the system transition to certain "degraded" modes when necessary, independently of the metacontrol, then I think we need to also observe these events for the metacontrol to have an appropriate response to it.
-
But if we decide that any system adaptation, including all mode transitions, can only be initiated by the metacontrol, then I guess there would be no need to observe it, apart from maybe observe it to confirm the success of a requested mode transition.
What would be your preferred design @norro ?
from mros_modes_observer.
I think you're right, Carlos, this is indeed a design decision. And when you put it like that I would suggest we go for the 2. option to have it more consistent.
So this issue is then more of a enhancement, which is probably not required in the near future - not even for the Bosch pilot.
from mros_modes_observer.
If you currently only rely on error
and inactive
, this is fine I guess.
Metacontrol might want to react on nodes/systems going into a certain (degraded?) mode. In the Bosch Pilot, we planed for this up to now.
@chcorbato what do you think?
from mros_modes_observer.
Superseeded by #2
from mros_modes_observer.
Related Issues (2)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mros_modes_observer.