Comments (5)
Sorry for the delayed response, life got in the way!
Could put the details of the problem into the ticket, please? I don't know what is wrong with the current code.
Could you please also add one or more unit tests?
from fluxor.
Thank you, I appreciate your contribution and your patience!
from fluxor.
I don't know what unit tests you can add. I usually look at the unit tests to understand the purpose of the code.
I'm putting together V6 at the moment, don't miss out :)
from fluxor.
I added that to handle routes Uri links as Uri links rather than as strings. Reason was the links with #fragments if I remember right.
As for the unit tests, sure, I will have a look what I can add. Perhaps, this weekend. Thanks!
from fluxor.
Hey @mrpmorris Sorry for delay. I got stuck figuring out what kind of test it could be... Any ideas are welcome.
Let me put some light on the reason why I needed that. Maybe it would be enough to merge this PR.
Blazor can't handle routes with fragments out of the box https://chrissainty.com/fragment-routing-with-blazor/
Saying fragments, I mean those URI Fragment part of anchor links to jump to a specific part of a page like this below:
<a href="#anchor-name">Jump to the part of the page with the “anchor-name” id </a>
In the app I am working on I have a page with tabs, which are handled by Blazor and use Fluxor.Blazor.Web.Middlewares.Routing.GoAction and routing middleware to navigate between tabs, and identify the which NavLink is active at the moment (to highlight on UI). In addition to that I have on-page navigation with "fragments" pointing to some element IDs on the page. I am trying to reduce using NavigationManager directly and instead - use routing middleware to handle in app navigation. So all navigation (without force page reloading and with it (when needed) is built on top of Fluxor.Blazor.Web.Middlewares.Routing
classes.
To check if the route is the same in HandleGoActionAsync
you just strings from NavigationManager.Uri
and let it be navigated if the strings are different. For links with URI fragment it could a bit be more sophisticated if UrlComparer
would sompare URIs rather than strings.
Please let me know what sort of test I could add for this PR, or feel free to merge the PR. Thanks!
from fluxor.
Related Issues (20)
- .NET 8 server-side rendering doesn't work with Fluxor HOT 6
- RobiniaDocs API Explorer
- Can't locate issue HOT 6
- Fluxor on Blazor .NET 8 Preview RC2 HOT 1
- Is there a way to use Fluxor with the new Blazor Web App paradigm? .NET8.0 HOT 37
- StoreInitializer not working in Balzor .net 8 HOT 4
- Fluxor.Blazor.Web.Components.FluxorComponent does not work in .NET 8 HOT 2
- Fluxor dont work with new template .Net 8 and InteractiveServerRenderMode HOT 2
- Fluxor breaks ErrorBoundary in Blazor Wasm HOT 2
- Fluxor Redux Dev Tools eating ram HOT 5
- Fluxor.Blazor.Web.ReduxDevTools requires script-src 'unsafe-eval' on CSP HOT 1
- Subscribing external events HOT 2
- Blazor server app in used Redux(Fluxor) in asp .net core error Unable to resolve service for type 'Fluxor.IFeature` while attempting to activate 'Fluxor.State` HOT 2
- Dispatch from Polly HOT 4
- Dispatching action in effect - running orders HOT 1
- Fluxor does not seem to work with the new .NET 8 Blazor Web App template HOT 2
- Deadlock when dispatching from store/feature events HOT 3
- Reducer not getting invoked in .NET 8 Blazor HOT 2
- Test case for dispatcher failure in .NET8 with new render modes HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fluxor.