Comments (2)
Thanks for looking into this. Definitely seems like remnants from when we moved from Scala to Java.
According to the old Scala code, ITransmissionAPI#getBundledInput
should give you the incoming signal to the block specified, meaning it will offset the given pos towards the face, then ask that neighbor block for its output. The function BundledSignalsLib.getBundledInput
actually does this (see line 36), while the other does not (I believe I started writing this method in TransmissionAPI, then realized it fits better in BundledSignalsLib, copied it there, and forgot to redirect the call).
This is also why the IBundledRedstoneProvider
I implemented offsets the side/face. Your API is an output getter, while mine is an input getter, so it has to operate from the other block's perspective. At the time, both of our APIs were stable so I couldn't just change mine to match unfortunately. Maybe I'll revisit it.
So overall, I think we fix it like this:
- For ProjectRed -> CC, point
TransmissionAPI.getBundledInput
toBundledSignalsLib.getBundledInput
. This alone should fix probing. - For CC -> ProjectRed, like you said, there's a bug with the sides that PR's cables are querying interactions with. Looking into this now.
from projectred.
Found it! Here, the Bundled Cable asks its neighbor for a bundled signal. This line specifically is for registered interactions. For whatever reason, it's using the rotation index rather than converting it into a direction index.
Instead it should be doing what line 230 does, converting that rotation to direction.
Same deal with Bundled gate parts:
from projectred.
Related Issues (20)
- 1.18.2 Map corrupts when placing Generator-Cable-Battery-Cable-Frame Motor HOT 4
- Fatally missing registry entries on server join HOT 2
- [1.18] ProjectRed conflicts on new world creation in a modpack HOT 3
- [Suggestion-Feature-1.12.2-Fabrication] Bundled Cable Null Cell HOT 1
- DEDICATED_SERVER ENV GUIs do not work HOT 1
- [1.18.2] Incompatible with Waterlogged Redstone HOT 3
- [1.18.2] Conflict with JourneyMap Waypoints HOT 5
- 1.18.2 Rubidium Rendering Issue HOT 1
- The source code for version 1.7.10 of the mod HOT 4
- [1.12.2] Stock keeper chips & Mass Fab HOT 1
- [1.12.2] Pipes item rendering & FPS
- Projectredp-transportation HOT 1
- Botania Structure Visualisation breaks with ProjectRed Core installed HOT 4
- (1.18.2) Game Freeze If Output Of Bus Converter Is Connected To Redstone Input Of Bus Input Panel And Is Powered HOT 1
- [1.18.2] [Bug] Motors cannot push stuff out of chunk (modulus) HOT 2
- How to Use New Fabrication System
- Electrotine ore should be a part of Fabrication
- [Bug] CC: Tweaked not see redstone bundled signals from Bundled Cables HOT 1
- GUI ERROR when accessing Timers & Other Gates HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from projectred.