GithubHelp home page GithubHelp logo

Comments (8)

jenneron avatar jenneron commented on July 19, 2024

If we get the whole idea going I could help you with pushing binaries to fwupd repo automatically using GitHub Actions

from lk2nd.

jenneron avatar jenneron commented on July 19, 2024

Also, I hope we can stop maintaining lk2nd packages in pmaports, but I'm not sure why these are there in the first place

from lk2nd.

TravMurav avatar TravMurav commented on July 19, 2024

I've already implemented it in -next:

offset = fdt_path_offset(dtb, "/chosen");
if (offset < 0)
return 0;
ret = fdt_setprop_string(dtb, offset, "lk2nd,project", xstr(BOARD));
if (ret < 0)
return 0;
ret = fdt_setprop_string(dtb, offset, "lk2nd,version", LK2ND_VERSION);
if (ret < 0)
return 0;

from lk2nd.

jenneron avatar jenneron commented on July 19, 2024

@TravMurav nice, lol. But I would still like to point this:

Note that I suggest having some generic prefix like bootloader, instead of lk2nd,, so we can use this approach in other bootloaders, e.g. U-Boot + extlinux

We have been thinking about the same thing for tegra devices using u-boot, so it would be nice to have common fwupd solution

from lk2nd.

TravMurav avatar TravMurav commented on July 19, 2024

hm, interesting, if we can get wide-ish support for those properties, then it would be really nice, not sure if we have any upstream to give us guidance on that though, but bootloader, sounds sad as a vendor prefix, in which case I'd do

&{/chosen} {
    bootloader {
        name = "lk2nd";
        version = "18.0"
        lk2nd,project = "lk2nd-msm8916"
    };
};

or something like that, not exactly sure what would be a nice, scalable solution here

(...) i.e. I'm not sure if "subtype" would be generic enough to apply to everyone.

from lk2nd.

jenneron avatar jenneron commented on July 19, 2024

if you have this for lk2nd:

&{/chosen} {
    bootloader {
        name = "lk2nd";
        type = "lk2nd-msm8916";
        version = "18.0";
    };
};

we would have this for u-boot on tegra:

&{/chosen} {
    bootloader {
        name = "U-Boot (grate-drivers)"; // the name is U-Boot, but we use it in the fork, so let's specify fork here as well to distinguish them
        type = "asus-grouper"; // u-boot builds are per-device, so let's do it here
        version = "2024.01";
    };
};

(just to give you an idea what i want from U-Boot side)

from lk2nd.

jenneron avatar jenneron commented on July 19, 2024

it would be also nice to have stage = "primary" or stage = "secondary" under bootloader node

from lk2nd.

jenneron avatar jenneron commented on July 19, 2024

maybe something like this would be better for us:

&{/chosen} {
    bootloader {
        name = "U-Boot";
        type = "grate-drivers"
        device = "asus-grouper";
        version = "2024.01";
    };
};

from lk2nd.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.