DCMAKE_CROSSCOMPILE flag in build-llvm.sh about llvm-mingw

[mstorsjo]

Thanks for picking up on this!

As a counter test I removed the flag all together (the build quickly failed).

Oh, where did it fail? As it seems to me right now, the existing flag I've been setting hasn't had any effect whatsoever, and with some initial testing, building works just as well without the flag altogether. (I didn't run that compile very far, but at least a hundred files in, or so).

I'll get the flag corrected in any case.

For what it's worth, build-libcxx.sh also prints a few of these warnings, but there, those flags are set much more intentionally than this misspelling. (Some of those are not recognized by cmake as proper external options, but still override some internal variables in the libcxx cmake files to make things build properly. For example, when building libunwind/libcxxabi, one still doesn't have a full proper C++ compiler environment, as there's no libc++ that can be linked in, to test the C++ functionality, so I need to set a few options to waive those tests. All of that is still a bit hacky still.)

[mstorsjo]

Fixed the option on master in 84bdd9c.

[ryderjgillen]

Oh, where did it fail? As it seems to me right now, the existing flag I've been setting hasn't had any effect whatsoever, and with some initial testing, building works just as well without the flag altogether. (I didn't run that compile very far, but at least a hundred files in, or so).

Interesting... it failed during the cmake dependency checking (I cant recall the exact error... something about not finding a part of the toolchain). I did have a few differences in my environment as I am rebuilding the images to better suit my needs (Debian+Clang/LLVM/lld for initial compile, I found some benchmarks showing it compiles slightly faster with Clang)

[mstorsjo]

Interesting... it failed during the cmake dependency checking (I cant recall the exact error).

Hmm, ok. In that case I would have expected it to fail similarly in the original form, with the misspelled option as well.

In any case, there's probably no need to dig further in those exact details anyway. It was misspelled, but worked for me by pure luck so far. Thanks!