GithubHelp home page GithubHelp logo

Comments (4)

msuchane avatar msuchane commented on June 28, 2024

Lenka, Gabi, and Lucie all prefer option 1 (empty files).

Alternatively, Lucie is partial to option 4 (commented-out includes) with an all-caps warning.

from acorns.

jamsmithredhat avatar jamsmithredhat commented on June 28, 2024

James is ok with option 1 (empty files) or option 4 (commented-out includes).
Would like to see a solution soon.
Getting an error message, manually commenting out the include statement, and rebuilding is disruptive.
Even worse it the risk of commenting out an include statement and neglecting to uncomment it when you get some bugs that belong in the included file.
Thanks

from acorns.

msuchane avatar msuchane commented on June 28, 2024

I'm happy with the "empty files" solution.

I was hesitant to implement it because empty assemblies technically violate FCC modularity rules, and our future tooling could have had a problem with it. At this point, it's no longer an issue, and I believe that the convenience of reliably working include statements greatly outweighs the theoretical modularity issues.

I'm going to implement this behavior shortly.

from acorns.

msuchane avatar msuchane commented on June 28, 2024

@jamsmithredhat, I've resolved this issue, choosing option 1.

With version 1.0.0, acorns now generates empty AsciiDoc files for all top-level assemblies that are empty. As such, you can include all assemblies in your master file, and the include directives won't break.

from acorns.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.