Comments (1)
Hi, @Lesstat. Thanks for raising this!
This has been brought up in the past, and I've decided not to support custom error messages with HttpResponse.error()
. There are two reasons for it.
Reason 1: Response.error()
The HttpResponse.error()
static method is modeled after the standard Response.error()
, which does not support any arguments, representing a generic network error when processing a request. Staying consistent here means predictable behavior, and I value that quite a lot.
Reason 2: Inconsistent error handling
MSW v1 used to have a NetworkError
class that supported custom error messages. It has quickly taught us that it is up to the request client to forward that error message to you, and some widely-used clients do not do that at all. This results in inconsistent errors, degrading the experience (and also producing different behavior based on what request client you're using, which we are trying to eliminate here at MSW).
I hope this gives you some insight as to why this wouldn't be a good idea to introduce.
When I stumbled upon your issue, I also noticed that we still recommended throwing errors in response resolvers in the docs. I've updated the HttpResponse.error()
page, also providing a short summary as to why we are not supporting custom error messages.
from msw.
Related Issues (20)
- Update 2.x removeAllListeners documentation
- Uncaught SyntaxError: Unexpected string (at msw.js?v=2dd0a77b:2057:51) HOT 2
- Include GraphQL operation name in the unhandled request warning HOT 3
- Trying to pull body in POST mocks breaks mocking HOT 3
- Error: [MSW] Failed to locate the Service Worker registration.
- Issue when no response.url and request is undefined
- msw/node unable to intercept requests from fetch in undici HOT 3
- request.formData() fails with vitest and file HOT 5
- Make bad "Network behavior overrides" more obvious HOT 1
- Optional path parameters do not match correctly HOT 4
- Always results in Network Error when using undici 6.x HOT 1
- Recieving `Network error` after moving to codegen msw handlers, various dependency upgrades and the addition of RTK query.
- Unclear how to throw an actual error HOT 1
- Axios fails to follow redirects from MSW mocked responses HOT 2
- FormData with file fails in with-jest HOT 2
- Native fetch is intercepted, but openapi-fetch call makes actual request HOT 3
- Cookie with path other than root not sent to handlers
- intercepted request won't abort on node 20 w/ [email protected]
- List "graphql" as a peer dependency HOT 3
- Addition of Boundary() to setupServer() in react-native with help of AsyncLocalStorage alternative in RN
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from msw.