Comments (8)
The Makefile currently passes LDFLAGS at the end of the $(CC) line, so I do not
see
the problem in the context of that doc?
Your patch just renames LDFLAGS to LIBS.
Original comment by [email protected]
on 23 Mar 2010 at 7:20
- Added labels: Priority-Low
- Removed labels: Priority-Medium
from skipfish.
I mean, you could just as easily keep LDFLAGS named as-is, and include env
ADD_LDFLAGS
for your needs, but I don't understand what this is trying to accomplish - if
something distro-specific, why not just apply a patch to add the options you
want?
Original comment by [email protected]
on 23 Mar 2010 at 7:23
from skipfish.
[And for what it's worth, I'm pretty sure that --as-needed makes absolutely no
difference for skipfish, as it does not come with any elaborate linking
dependencies.]
Original comment by [email protected]
on 23 Mar 2010 at 7:25
from skipfish.
The general part:
It makes sense to respect standard environment variables and when you can add
+= and
?= operators to Makefile, it's also easy... there's no need to "invent" more
names
for them.
The distro specific part:
The LDFLAGS come from the /etc/make.conf gentoo-distro specific file to the
package
manager (Portage, in this case) and gets exported to environment for
build-time. So
when I have LDFLAGS="-Wl,--as-needed" in /etc/make.conf, I expect every single
package to use it.
That said, there's likely not much gain for you as upstream to add this feature
to
skipfish, but I'm asking you still do, just to make it compatible with Gentoo's
standards and we can easily include your software :)
Thanks!
Original comment by [email protected]
on 23 Mar 2010 at 9:45
from skipfish.
Just some example,
http://sources.redhat.com/automake/automake.html#Standard-Configuration-Variable
s
e.g. -D flags go to CPPFLAGS += -Dsomething
optimization flags for CC go as CFLAGS += -O3 -g -ggdb
extra LDFLAGS go as LDFLAGS += -Wl,-something
default CC goes as something like CC ?= gcc
Then
$(CC) $(LDFLAGS) $(CFLAGS) $(CPPFLAGS) $(objects-variable) $(libs-variable)
Original comment by [email protected]
on 23 Mar 2010 at 9:52
from skipfish.
Some references to similar fixing,
http://blog.flameeyes.eu/2008/10/15/fixing-cflags-ldflags-handling-with-a-single
-boilerplate-makefile
http://www.mail-archive.com/[email protected]/msg19082.html
Original comment by [email protected]
on 23 Mar 2010 at 9:58
from skipfish.
Ok, thanks for the explanation. The upcoming version will honor external
CFLAGS,
LDFLAGS, just pending some other bugfixes.
Original comment by [email protected]
on 23 Mar 2010 at 5:03
- Changed state: Fixed
from skipfish.
thanks :)
meanwhile, i've packaged skipfish
http://packages.gentoo.org/package/dev-util/skipfish
Original comment by [email protected]
on 23 Mar 2010 at 6:39
from skipfish.
Related Issues (20)
- Skipfish -I option doesn't properly work HOT 1
- Skipfish to slow under cygwin HOT 1
- I cant get google play to open. HOT 1
- Patch for /trunk/README
- on Gmail Search button not working properely refreshes the page instead of doing search operations HOT 1
- Add ability to exclude pages by content
- Enter one-line summary
- URL for arachni has changed
- how it work? HOT 1
- Preprocessor use of USE_COLOR (config.h, debug.h) is inconsistent
- Documentation detailing how vulnerabilities are determined
- Hello HOT 1
- Getting the Authentication error even after login form has been authenticated.
- "><img src=x onerror=prompt(0)> HOT 2
- Enter one-line summary
- Use Firing Range to make sure the scanner is tested for recognition of modern vulnerabilities HOT 1
- did my husband add his email on mine so he can see everything i do? All his adresses ad to mine is there a connection spmewhere to [email protected] his email?
- ive been hackedbyyour iwn tools HOT 1
- Install Skipfish globally in Ubuntu 14.04
- Enter one-line summary
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from skipfish.