GithubHelp home page GithubHelp logo

Comments (2)

siriwatknp avatar siriwatknp commented on April 28, 2024

This is because getColorSchemeSelector is appended by CssVarsProvider because the function needs attribute from CssVarsProvider's props.

I think we can improve this by delegating the attribute to the extendTheme and set getColorSchemeSelector to the theme. With this, zero-runtime can read and use the attribute internally cc @brijeshb42

from material-ui.

mtr1990 avatar mtr1990 commented on April 28, 2024

Thank you for providing feedback.

If we can deliver in extendTheme instead of under CssVarsProvider then customization will be better

Currently I can temporarily rewrite the getColorSchemeSelector function for use:

export function getMode(mode) {
  if (mode === 'light') {
    return `[data-mui-color-scheme="light"] &`;
  }
  return `[data-mui-color-scheme="dark"] &`;
}

But I realized other functions like pallet also don't work inside extendTheme like Mui Joy.

My need is to customize the theme before creating in <CssVarsProvider theme={theme}>

So I need properties like mode (console.log("palette", theme.palette.mode);)

There is also solution for this using global state. But then const { mode, setMode } = useColorScheme(); will lose its meaning and we have to write some extra code to further handle the mode state, which is not necessary

image

Hopefully this will improve.

from material-ui.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.