GithubHelp home page GithubHelp logo

Comments (6)

danilo-leal avatar danilo-leal commented on May 18, 2024
  1. Broken Tabs aria-role on https://mui.com/base-ui/react-button/components-api/

About the last item on the list: I'm assuming we can only fix this if we change the approach from having the Tab render an <a> tag to rendering an actual <button>, right? I've tried to fix this issue, and from what I've looked around, it's very uncommon to have tabs with links instead of buttons. I'm also wondering if the item above (broken arrow navigation) has anything to do with this...

from material-ui.

oliviertassinari avatar oliviertassinari commented on May 18, 2024

it's very uncommon to have tabs with links instead of buttons

@danilo-leal I disagree, using links with tabs looks common to me. The closer the tabs is to the top of the page, the more likely its state should be stored in the URL. For example, we need to change from button to link in https://github.com/mui/mui-private/issues/392 for the tabs of the store product pages. Or on this very page, the top is a list of tabs with links: https://primer.style/components/tab-nav/react/alpha.

Or on https://hub.docker.com/repositories/, looks like they used the tabs as link

SCR-20240223-cetz

from material-ui.

danilo-leal avatar danilo-leal commented on May 18, 2024

That's true, okay. But I'm more curious whether that's part of the problem with the wrong aria-role and keyboard navigation. For example, The Material UI tabs component — which is what we're using for the page's tabs — seems to be fine on these two aspects if the Tab is rendered as a button.

from material-ui.

danilo-leal avatar danilo-leal commented on May 18, 2024

However, maybe the GitHub example is not the best as they don't seem to use role="tablist" both in the Primer docs and here. So, it visually looks like a Tabs component, but they're not intending it to be that way under the hood? Anyway, it makes me wonder even more about the question above...

from material-ui.

oliviertassinari avatar oliviertassinari commented on May 18, 2024

@danilo-leal I suspect an issue with Base UI Tabs component.

from material-ui.

danilo-leal avatar danilo-leal commented on May 18, 2024

Yup, but those things are happening to the Material UI Tabs; it's what the page uses, so maybe there's a bug there, too.

from material-ui.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.