Comments (6)
- Broken Tabs aria-role on https://mui.com/base-ui/react-button/components-api/
About the last item on the list: I'm assuming we can only fix this if we change the approach from having the Tab render an <a>
tag to rendering an actual <button>
, right? I've tried to fix this issue, and from what I've looked around, it's very uncommon to have tabs with links instead of buttons. I'm also wondering if the item above (broken arrow navigation) has anything to do with this...
from material-ui.
it's very uncommon to have tabs with links instead of buttons
@danilo-leal I disagree, using links with tabs looks common to me. The closer the tabs is to the top of the page, the more likely its state should be stored in the URL. For example, we need to change from button to link in https://github.com/mui/mui-private/issues/392 for the tabs of the store product pages. Or on this very page, the top is a list of tabs with links: https://primer.style/components/tab-nav/react/alpha.
Or on https://hub.docker.com/repositories/, looks like they used the tabs as link
from material-ui.
That's true, okay. But I'm more curious whether that's part of the problem with the wrong aria-role and keyboard navigation. For example, The Material UI tabs component — which is what we're using for the page's tabs — seems to be fine on these two aspects if the Tab is rendered as a button.
from material-ui.
However, maybe the GitHub example is not the best as they don't seem to use role="tablist"
both in the Primer docs and here. So, it visually looks like a Tabs component, but they're not intending it to be that way under the hood? Anyway, it makes me wonder even more about the question above...
from material-ui.
@danilo-leal I suspect an issue with Base UI Tabs component.
from material-ui.
Yup, but those things are happening to the Material UI Tabs; it's what the page uses, so maybe there's a bug there, too.
from material-ui.
Related Issues (20)
- [material-ui][Popover] Breaking the Paper styles of non-popover components HOT 2
- [material-ui] Add a Split Pane component HOT 2
- Black border appears on the Outline of the Joy UI Modal HOT 2
- [material-ui][Table] `slots` and `slotProps` documented properties are not exposed in package HOT 6
- [material-ui][Grid] Wrapped Unstable_Grid2 containers increasing height for each word in a grid item HOT 3
- [material-ui][Drawer] How to set all drawers under the appbar? HOT 4
- [system] Improve documentation on usage of layout components: Container, Grid, Box, Stack HOT 1
- [zero-runtime] Add RTL support HOT 6
- [system][zero] Consolidate the arguments in the variant's props callback
- [docs-infra] Embed the Google package in writing-rules HOT 1
- [material-ui][Autocomplete]: Add class for component when `multiple` prop is used HOT 1
- [types] Make OverridableComponentAugmentation default
- [material-ui][Popover] Incorrect position inside CSS inline-size container HOT 1
- [base-ui][useSelect] onChange not working when activated through keyboard (Enter or Space key press) HOT 5
- [docs-infra] The docs with RTL break the dark theme HOT 1
- [autocomplete][table] How to insert an Autocomplete in a table row? HOT 3
- [material-ui] RadioGroup triggers Onchange event twice on value change within React Js project HOT 2
- [material-ui][Grid] Deprecate the `wrap` prop
- [material-ui][Collapse] Deprecate `sx` prop HOT 3
- [system] Remove createUseThemeProps API HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from material-ui.