GithubHelp home page GithubHelp logo

Comments (14)

mundschenk-at avatar mundschenk-at commented on June 16, 2024

Two conflicting browser bugs - well, there's not much I can do about it (except maybe some conditional comments - does IE11 still parse these?). Also, the problem does not happen when you use a font other than Noto Sans. There's probably something funky with its ligatures.

from wp-typography.

mundschenk-at avatar mundschenk-at commented on June 16, 2024

OK, apparently this is connected with https://connect.microsoft.com/IE/feedbackdetail/view/831964 and only happens on Windows < 8. While one could probably create some IE11-only CSS via a special media query, I'm not sure it is worth the effort.

from wp-typography.

sarukuku avatar sarukuku commented on June 16, 2024

IE11 doesn't support conditional comments anymore. I think IE9 was the last one to support those.

It's good that the IE team hans an issue open for that bug already. Maybe leave this bug open and track the IE issue from time to time?

Also it would be possible to add a comment to the plugin under the option that this style is global and warns about this bug. The comment could be removed if / when the bug in IE10/11 gets fixed.

from wp-typography.

mundschenk-at avatar mundschenk-at commented on June 16, 2024

Microsoft is not fixing non-security bugs on anything other than Edge anymore, so tracking the bug won't do any good.

from wp-typography.

sarukuku avatar sarukuku commented on June 16, 2024

Ah, ok. Then I guess it's a lost cause. Well at least here's an issue of this with some extra info if someone happens to run to this. Consider adding the message though. :)

from wp-typography.

elbstrand avatar elbstrand commented on June 16, 2024

This fixes the safari bug without the problems in IE:

body {
    -webkit-font-variant-ligatures: no-common-ligatures;
    font-variant-ligatures: no-common-ligatures;
}

from wp-typography.

mundschenk-at avatar mundschenk-at commented on June 16, 2024

But it also disables ligatures.

from wp-typography.

elbstrand avatar elbstrand commented on June 16, 2024

Maybe thats a matter of taste, but i rather have no (common) ligatures then destroyed text in safari or no text in IE.

from wp-typography.

mundschenk-at avatar mundschenk-at commented on June 16, 2024

The IE bug is only triggered on Windows 7 and not with all fonts. Everyone is free to use their own CSS tailored to their font usage.

from wp-typography.

elbstrand avatar elbstrand commented on June 16, 2024

You are aware that Windows 7 still has a 40% marketshare among desktop computers?

from wp-typography.

mundschenk-at avatar mundschenk-at commented on June 16, 2024

That's why this ticket has not been closed yet.

from wp-typography.

mundschenk-at avatar mundschenk-at commented on June 16, 2024

The problem might be fixable by adding -ms-font-feature-settings: normal; to the current Safari workaround.

from wp-typography.

elbstrand avatar elbstrand commented on June 16, 2024

I've heard that the -ms prefix doesnt work with newer IE browser, have to check tho

from wp-typography.

mundschenk-at avatar mundschenk-at commented on June 16, 2024

It's deprecated and it may not work for certain properties, but as far as can tell it works for IE11 on Windows 7 (at least for version 11.0.9600.18376).

from wp-typography.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.