ACF support about wp-typography

[sarukuku]

+1

[roopemerikukka]

Hi,

I just noticed that you have used the acf/format_value_for_api filter which has been renamed to acf/format_value in v5.0.0 and later so the current solution only works with older ACF versions.

https://www.advancedcustomfields.com/resources/acfformat_value/

I have tested this by changing the name to the new one and got mine working after that.

[mundschenk-at]

That's because 4.4.8 is the latest free version of ACF.

[roopemerikukka]

A lot of people are using ACF Pro also. How about checking the ACF version and then choosing which hooks to use? You can get the acf major version (at least in 5) with intval( acf_get_setting('version') );.

And second thought about the hooks used. At least we use the text fields in various ways and also for data like keys and such that we wouldn't necessary want to get hyphenated. Could there be a checkboxes in options where you could select which field types to apply instead of just doing it automatically for all fields? I understand it with the wysiwyg field but the text and textarea fields might be used in ways where hyphenation isn't wanted.

[mundschenk-at]

I don't have access to ACF Pro, so I cannot test the code. (Philosophically, I'm not sure I want to support a premium plugin where the free version has not been updated to the next major release in such a long time.)

However, I suggest you create two separate enhancement requests and we'll continue the discussion there (it's easier to keep track of things if tickets cover a single issue).